Skip to content

Commit 03a23c8

Browse files
committed
Make all share tests final
Drivers wanting to run custom tests should define them in their own tests. They might also decide to skip some of the shared tests. But there is no reason to customize the shared tests themselves.
1 parent b6e6994 commit 03a23c8

23 files changed

Lines changed: 23 additions & 23 deletions

tests/Basic/BasicAuthTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use Behat\Mink\Tests\Driver\TestCase;
66

7-
class BasicAuthTest extends TestCase
7+
final class BasicAuthTest extends TestCase
88
{
99
/**
1010
* @dataProvider setBasicAuthDataProvider

tests/Basic/BestPracticesTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
/**
88
* This testcase ensures that the driver implementation follows recommended practices for drivers.
99
*/
10-
class BestPracticesTest extends TestCase
10+
final class BestPracticesTest extends TestCase
1111
{
1212
public function testExtendsCoreDriver()
1313
{

tests/Basic/ContentTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use Behat\Mink\Tests\Driver\TestCase;
66

7-
class ContentTest extends TestCase
7+
final class ContentTest extends TestCase
88
{
99
public function testOuterHtml()
1010
{

tests/Basic/CookieTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use Behat\Mink\Tests\Driver\TestCase;
66

7-
class CookieTest extends TestCase
7+
final class CookieTest extends TestCase
88
{
99
/**
1010
* test cookie decoding.

tests/Basic/ErrorHandlingTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
/**
88
* @group slow
99
*/
10-
class ErrorHandlingTest extends TestCase
10+
final class ErrorHandlingTest extends TestCase
1111
{
1212
const NOT_FOUND_XPATH = '//html/./invalid';
1313

tests/Basic/HeaderTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use Behat\Mink\Tests\Driver\TestCase;
66

7-
class HeaderTest extends TestCase
7+
final class HeaderTest extends TestCase
88
{
99
/**
1010
* test referrer.

tests/Basic/IFrameTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use Behat\Mink\Tests\Driver\TestCase;
66

7-
class IFrameTest extends TestCase
7+
final class IFrameTest extends TestCase
88
{
99
public function testIFrame()
1010
{

tests/Basic/NavigationTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
use Behat\Mink\Tests\Driver\TestCase;
66
use Yoast\PHPUnitPolyfills\Polyfills\AssertionRenames;
77

8-
class NavigationTest extends TestCase
8+
final class NavigationTest extends TestCase
99
{
1010
use AssertionRenames;
1111

tests/Basic/ScreenshotTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use Behat\Mink\Tests\Driver\TestCase;
66

7-
class ScreenshotTest extends TestCase
7+
final class ScreenshotTest extends TestCase
88
{
99
public function testScreenshot()
1010
{

tests/Basic/StatusCodeTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use Behat\Mink\Tests\Driver\TestCase;
66

7-
class StatusCodeTest extends TestCase
7+
final class StatusCodeTest extends TestCase
88
{
99
public function testStatuses()
1010
{

0 commit comments

Comments
 (0)