Improve testWindowMaximize

uuf6429 · uuf6429 · commit 93d4eafb7bd5 · 2023-07-09T21:17:50.000+02:00
diff --git a/tests/Js/WindowTest.php b/tests/Js/WindowTest.php
@@ -102,8 +102,9 @@ public function testWindowMaximize()
         $session->maximizeWindow();
         $session->wait(1000, 'false');
 
-        $script = 'return Math.abs(screen.availHeight - window.outerHeight);';
-
-        $this->assertLessThanOrEqual(100, $session->evaluateScript($script));
+        $unusedWidth = $session->evaluateScript('screen.availWidth - window.outerWidth');
+        $unusedHeight = $session->evaluateScript('screen.availHeight - window.outerHeight');
+        $this->assertLessThanOrEqual(0, $unusedWidth);
+        $this->assertLessThanOrEqual(0, $unusedHeight);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -102,8 +102,9 @@ public function testWindowMaximize()`
`102`	`102`	`$session->maximizeWindow();`
`103`	`103`	`$session->wait(1000, 'false');`
`104`	`104`
`105`		`- $script = 'return Math.abs(screen.availHeight - window.outerHeight);';`
`106`		`-`
`107`		`- $this->assertLessThanOrEqual(100, $session->evaluateScript($script));`
	`105`	`+ $unusedWidth = $session->evaluateScript('screen.availWidth - window.outerWidth');`
	`106`	`+ $unusedHeight = $session->evaluateScript('screen.availHeight - window.outerHeight');`
	`107`	`+ $this->assertLessThanOrEqual(0, $unusedWidth);`
	`108`	`+ $this->assertLessThanOrEqual(0, $unusedHeight);`
`108`	`109`	`}`
`109`	`110`	`}`