Merge pull request #63 from stof/static_dataproviders

stof · web-flow · commit 9f2fb574d832 · 2023-02-15T10:44:49.000+01:00
Migrate to static data-providers
diff --git a/tests/Basic/BasicAuthTest.php b/tests/Basic/BasicAuthTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class BasicAuthTest extends TestCase
+final class BasicAuthTest extends TestCase
 {
     /**
      * @dataProvider setBasicAuthDataProvider
@@ -20,7 +20,7 @@ public function testSetBasicAuth($user, $pass, $pageText)
         $this->assertStringContainsString($pageText, $session->getPage()->getContent());
     }
 
-    public function setBasicAuthDataProvider()
+    public static function setBasicAuthDataProvider()
     {
         return array(
             array('mink-user', 'mink-password', 'is authenticated'),
diff --git a/tests/Basic/BestPracticesTest.php b/tests/Basic/BestPracticesTest.php
@@ -7,7 +7,7 @@
 /**
  * This testcase ensures that the driver implementation follows recommended practices for drivers.
  */
-class BestPracticesTest extends TestCase
+final class BestPracticesTest extends TestCase
 {
     public function testExtendsCoreDriver()
     {
@@ -40,7 +40,7 @@ public function testImplementBasicApi($method)
         $this->assertImplementMethod($method, $driver, 'The driver is unusable when this method is not implemented.');
     }
 
-    public function provideRequiredMethods()
+    public static function provideRequiredMethods()
     {
         return array(
             array('start'),
diff --git a/tests/Basic/ContentTest.php b/tests/Basic/ContentTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class ContentTest extends TestCase
+final class ContentTest extends TestCase
 {
     public function testOuterHtml()
     {
@@ -46,7 +46,7 @@ public function testGetAttribute($attributeName, $attributeValue)
         $this->assertSame($attributeValue, $element->getAttribute($attributeName));
     }
 
-    public function getAttributeDataProvider()
+    public static function getAttributeDataProvider()
     {
         return array(
             array('with-value', 'some-value'),
diff --git a/tests/Basic/CookieTest.php b/tests/Basic/CookieTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class CookieTest extends TestCase
+final class CookieTest extends TestCase
 {
     /**
      * test cookie decoding.
@@ -87,7 +87,7 @@ public function testCookieWithPaths($cookieRemovalMode)
         $this->assertStringContainsString('Previous cookie: NO', $session->getPage()->getText());
     }
 
-    public function cookieWithPathsDataProvider()
+    public static function cookieWithPathsDataProvider()
     {
         return array(
             array('session_reset'),
@@ -123,14 +123,6 @@ public function testCookieInSubPath($cookieRemovalMode)
         $this->assertStringContainsString('Previous cookie: NO', $session->getPage()->getText());
     }
 
-    public function cookieInSubPathProvider()
-    {
-        return array(
-            array('session_reset'),
-            array('cookie_delete'),
-        );
-    }
-
     public function testReset()
     {
         $this->getSession()->visit($this->pathTo('/cookie_page1.php'));
diff --git a/tests/Basic/ErrorHandlingTest.php b/tests/Basic/ErrorHandlingTest.php
@@ -7,7 +7,7 @@
 /**
  * @group slow
  */
-class ErrorHandlingTest extends TestCase
+final class ErrorHandlingTest extends TestCase
 {
     const NOT_FOUND_XPATH = '//html/./invalid';
 
diff --git a/tests/Basic/HeaderTest.php b/tests/Basic/HeaderTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class HeaderTest extends TestCase
+final class HeaderTest extends TestCase
 {
     /**
      * test referrer.
diff --git a/tests/Basic/IFrameTest.php b/tests/Basic/IFrameTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class IFrameTest extends TestCase
+final class IFrameTest extends TestCase
 {
     public function testIFrame()
     {
diff --git a/tests/Basic/NavigationTest.php b/tests/Basic/NavigationTest.php
@@ -5,7 +5,7 @@
 use Behat\Mink\Tests\Driver\TestCase;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertionRenames;
 
-class NavigationTest extends TestCase
+final class NavigationTest extends TestCase
 {
     use AssertionRenames;
 
diff --git a/tests/Basic/ScreenshotTest.php b/tests/Basic/ScreenshotTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class ScreenshotTest extends TestCase
+final class ScreenshotTest extends TestCase
 {
     public function testScreenshot()
     {
diff --git a/tests/Basic/StatusCodeTest.php b/tests/Basic/StatusCodeTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class StatusCodeTest extends TestCase
+final class StatusCodeTest extends TestCase
 {
     public function testStatuses()
     {
diff --git a/tests/Basic/TraversingTest.php b/tests/Basic/TraversingTest.php
@@ -5,7 +5,7 @@
 use Behat\Mink\Tests\Driver\TestCase;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertionRenames;
 
-class TraversingTest extends TestCase
+final class TraversingTest extends TestCase
 {
     use AssertionRenames;
 
diff --git a/tests/Basic/VisibilityTest.php b/tests/Basic/VisibilityTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class VisibilityTest extends TestCase
+final class VisibilityTest extends TestCase
 {
     public function testVisibility()
     {
diff --git a/tests/Css/HoverTest.php b/tests/Css/HoverTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class HoverTest extends TestCase
+final class HoverTest extends TestCase
 {
     /**
      * @group mouse-events
diff --git a/tests/Form/CheckboxTest.php b/tests/Form/CheckboxTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class CheckboxTest extends TestCase
+final class CheckboxTest extends TestCase
 {
     public function testManipulate()
     {
diff --git a/tests/Form/GeneralTest.php b/tests/Form/GeneralTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class GeneralTest extends TestCase
+final class GeneralTest extends TestCase
 {
     // test multiple submit buttons
     public function testIssue212()
@@ -76,7 +76,7 @@ public function testFormSubmitWays($submitVia)
         }
     }
 
-    public function formSubmitWaysDataProvider()
+    public static function formSubmitWaysDataProvider()
     {
         return array(
             array('Save'),
diff --git a/tests/Form/Html5Test.php b/tests/Form/Html5Test.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class Html5Test extends TestCase
+final class Html5Test extends TestCase
 {
     public function testHtml5FormInputAttribute()
     {
diff --git a/tests/Form/RadioTest.php b/tests/Form/RadioTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class RadioTest extends TestCase
+final class RadioTest extends TestCase
 {
     /**
      * @before
diff --git a/tests/Form/SelectTest.php b/tests/Form/SelectTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class SelectTest extends TestCase
+final class SelectTest extends TestCase
 {
     public function testMultiselect()
     {
@@ -77,7 +77,7 @@ public function testElementSelectedStateCheck($selectName, $optionValue, $option
         $this->assertTrue($option->isSelected());
     }
 
-    public function elementSelectedStateCheckDataProvider()
+    public static function elementSelectedStateCheckDataProvider()
     {
         return array(
             array('select_number', '30', 'thirty'),
diff --git a/tests/Js/ChangeEventTest.php b/tests/Js/ChangeEventTest.php
@@ -7,7 +7,7 @@
 /**
  * @group slow
  */
-class ChangeEventTest extends TestCase
+final class ChangeEventTest extends TestCase
 {
     /**
      * 'change' event should be fired after selecting an <option> in a <select>.
@@ -58,7 +58,7 @@ public function testSetValueChangeEvent($elementId, $valueForEmpty, $valueForFil
         }
     }
 
-    public function setValueChangeEventDataProvider()
+    public static function setValueChangeEventDataProvider()
     {
         $file1 = __DIR__ . '/../../web-fixtures/file1.txt';
         $file2 = __DIR__ . '/../../web-fixtures/file2.txt';
@@ -90,7 +90,7 @@ public function testSelectOptionChangeEvent($elementId, $elementValue)
         $this->assertElementChangeCount($elementId);
     }
 
-    public function selectOptionChangeEventDataProvider()
+    public static function selectOptionChangeEventDataProvider()
     {
         return array(
             'select' => array('the-select', '30'),
@@ -140,7 +140,7 @@ public function testUncheckChangeEvent($useSetValue)
         $this->assertElementChangeCount('the-checked-checkbox');
     }
 
-    public function checkboxTestWayDataProvider()
+    public static function checkboxTestWayDataProvider()
     {
         return array(
             array(true),
diff --git a/tests/Js/EventsTest.php b/tests/Js/EventsTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class EventsTest extends TestCase
+final class EventsTest extends TestCase
 {
     /**
      * @group mouse-events
@@ -114,7 +114,7 @@ public function testKeyboardEvents($modifier, $eventProperties)
         $this->assertEquals('key upped:78 / '.$eventProperties, $event->getText());
     }
 
-    public function provideKeyboardEventsModifiers()
+    public static function provideKeyboardEventsModifiers()
     {
         return array(
             'none' => array(null, '0 / 0 / 0 / 0'),
diff --git a/tests/Js/JavascriptEvaluationTest.php b/tests/Js/JavascriptEvaluationTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class JavascriptEvaluationTest extends TestCase
+final class JavascriptEvaluationTest extends TestCase
 {
     /**
      * Tests, that `wait` method returns check result after exit.
@@ -55,7 +55,7 @@ public function testExecuteScript($script)
         $this->assertEquals('Hello world', $heading->getText());
     }
 
-    public function provideExecutedScript()
+    public static function provideExecutedScript()
     {
         return array(
             array('document.querySelector("h1").textContent = "Hello world"'),
@@ -77,7 +77,7 @@ public function testEvaluateJavascript($script)
         $this->assertSame(2, $this->getSession()->evaluateScript($script));
     }
 
-    public function provideEvaluatedScript()
+    public static function provideEvaluatedScript()
     {
         return array(
             array('1 + 1'),
diff --git a/tests/Js/JavascriptTest.php b/tests/Js/JavascriptTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class JavascriptTest extends TestCase
+final class JavascriptTest extends TestCase
 {
     public function testAriaRoles()
     {
diff --git a/tests/Js/WindowTest.php b/tests/Js/WindowTest.php
@@ -4,7 +4,7 @@
 
 use Behat\Mink\Tests\Driver\TestCase;
 
-class WindowTest extends TestCase
+final class WindowTest extends TestCase
 {
     public function testWindow()
     {

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`use Behat\Mink\Tests\Driver\TestCase;`
`6`	`6`
`7`		`-class BasicAuthTest extends TestCase`
	`7`	`+final class BasicAuthTest extends TestCase`
`8`	`8`	`{`
`9`	`9`	`/**`
`10`	`10`	`* @dataProvider setBasicAuthDataProvider`
`@@ -20,7 +20,7 @@ public function testSetBasicAuth($user, $pass, $pageText)`
`20`	`20`	`$this->assertStringContainsString($pageText, $session->getPage()->getContent());`
`21`	`21`	`}`
`22`	`22`
`23`		`- public function setBasicAuthDataProvider()`
	`23`	`+ public static function setBasicAuthDataProvider()`
`24`	`24`	`{`
`25`	`25`	`return array(`
`26`	`26`	`array('mink-user', 'mink-password', 'is authenticated'),`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`/**`
`8`	`8`	`* This testcase ensures that the driver implementation follows recommended practices for drivers.`
`9`	`9`	`*/`
`10`		`-class BestPracticesTest extends TestCase`
	`10`	`+final class BestPracticesTest extends TestCase`
`11`	`11`	`{`
`12`	`12`	`public function testExtendsCoreDriver()`
`13`	`13`	`{`
`@@ -40,7 +40,7 @@ public function testImplementBasicApi($method)`
`40`	`40`	`$this->assertImplementMethod($method, $driver, 'The driver is unusable when this method is not implemented.');`
`41`	`41`	`}`
`42`	`42`
`43`		`- public function provideRequiredMethods()`
	`43`	`+ public static function provideRequiredMethods()`
`44`	`44`	`{`
`45`	`45`	`return array(`
`46`	`46`	`array('start'),`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`use Behat\Mink\Tests\Driver\TestCase;`
`6`	`6`
`7`		`-class ContentTest extends TestCase`
	`7`	`+final class ContentTest extends TestCase`
`8`	`8`	`{`
`9`	`9`	`public function testOuterHtml()`
`10`	`10`	`{`
`@@ -46,7 +46,7 @@ public function testGetAttribute($attributeName, $attributeValue)`
`46`	`46`	`$this->assertSame($attributeValue, $element->getAttribute($attributeName));`
`47`	`47`	`}`
`48`	`48`
`49`		`- public function getAttributeDataProvider()`
	`49`	`+ public static function getAttributeDataProvider()`
`50`	`50`	`{`
`51`	`51`	`return array(`
`52`	`52`	`array('with-value', 'some-value'),`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`use Behat\Mink\Tests\Driver\TestCase;`
`6`	`6`
`7`		`-class CookieTest extends TestCase`
	`7`	`+final class CookieTest extends TestCase`
`8`	`8`	`{`
`9`	`9`	`/**`
`10`	`10`	`* test cookie decoding.`
`@@ -87,7 +87,7 @@ public function testCookieWithPaths($cookieRemovalMode)`
`87`	`87`	`$this->assertStringContainsString('Previous cookie: NO', $session->getPage()->getText());`
`88`	`88`	`}`
`89`	`89`
`90`		`- public function cookieWithPathsDataProvider()`
	`90`	`+ public static function cookieWithPathsDataProvider()`
`91`	`91`	`{`
`92`	`92`	`return array(`
`93`	`93`	`array('session_reset'),`
`@@ -123,14 +123,6 @@ public function testCookieInSubPath($cookieRemovalMode)`
`123`	`123`	`$this->assertStringContainsString('Previous cookie: NO', $session->getPage()->getText());`
`124`	`124`	`}`
`125`	`125`
`126`		`- public function cookieInSubPathProvider()`
`127`		`- {`
`128`		`- return array(`
`129`		`- array('session_reset'),`
`130`		`- array('cookie_delete'),`
`131`		`- );`
`132`		`- }`
`133`		`-`
`134`	`126`	`public function testReset()`
`135`	`127`	`{`
`136`	`128`	`$this->getSession()->visit($this->pathTo('/cookie_page1.php'));`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`/**`
`8`	`8`	`* @group slow`
`9`	`9`	`*/`
`10`		`-class ErrorHandlingTest extends TestCase`
	`10`	`+final class ErrorHandlingTest extends TestCase`
`11`	`11`	`{`
`12`	`12`	`const NOT_FOUND_XPATH = '//html/./invalid';`
`13`	`13`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`use Behat\Mink\Tests\Driver\TestCase;`
`6`	`6`
`7`		`-class HeaderTest extends TestCase`
	`7`	`+final class HeaderTest extends TestCase`
`8`	`8`	`{`
`9`	`9`	`/**`
`10`	`10`	`* test referrer.`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`use Behat\Mink\Tests\Driver\TestCase;`
`6`	`6`
`7`		`-class IFrameTest extends TestCase`
	`7`	`+final class IFrameTest extends TestCase`
`8`	`8`	`{`
`9`	`9`	`public function testIFrame()`
`10`	`10`	`{`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`use Behat\Mink\Tests\Driver\TestCase;`
`6`	`6`	`use Yoast\PHPUnitPolyfills\Polyfills\AssertionRenames;`
`7`	`7`
`8`		`-class NavigationTest extends TestCase`
	`8`	`+final class NavigationTest extends TestCase`
`9`	`9`	`{`
`10`	`10`	`use AssertionRenames;`
`11`	`11`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`use Behat\Mink\Tests\Driver\TestCase;`
`6`	`6`
`7`		`-class ScreenshotTest extends TestCase`
	`7`	`+final class ScreenshotTest extends TestCase`
`8`	`8`	`{`
`9`	`9`	`public function testScreenshot()`
`10`	`10`	`{`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`use Behat\Mink\Tests\Driver\TestCase;`
`6`	`6`
`7`		`-class StatusCodeTest extends TestCase`
	`7`	`+final class StatusCodeTest extends TestCase`
`8`	`8`	`{`
`9`	`9`	`public function testStatuses()`
`10`	`10`	`{`