Consensus tightening - forbid pool id mismatch; some cleanup

Author: ImplOfAnImpl

chainstate/src/detail/ban_score.rs

@@ -476,6 +476,7 @@ impl BanScore for ConsensusPoSError {
             ConsensusPoSError::EmptyTimespan => 100,
             ConsensusPoSError::FailedToCalculateCappedBalance => 100,
             ConsensusPoSError::InvalidOutputTypeInStakeKernel(_) => 100,
+            ConsensusPoSError::PoolIdsInKernelUtxoAndPoSDataMismatch { .. } => 100,
         }
     }
 }

chainstate/src/detail/error_classification.rs

@@ -663,7 +663,8 @@ impl BlockProcessingErrorClassification for ConsensusPoSError {
             | ConsensusPoSError::FiniteTotalSupplyIsRequired
             | ConsensusPoSError::UnsupportedConsensusVersion
             | ConsensusPoSError::FailedToCalculateCappedBalance
-            | ConsensusPoSError::InvalidOutputTypeInStakeKernel(_) => {
+            | ConsensusPoSError::InvalidOutputTypeInStakeKernel(_)
+            | ConsensusPoSError::PoolIdsInKernelUtxoAndPoSDataMismatch { .. } => {
                 BlockProcessingErrorClass::BadBlock
             }
 

chainstate/src/detail/mod.rs

@@ -86,7 +86,7 @@ pub use self::{
     median_time::calculate_median_time_past_from_blocktimestamps,
 };
 pub use chainstate_types::Locator;
-pub use chainstateref::NonZeroPoolBalances;
+pub use chainstateref::{EpochSealError, NonZeroPoolBalances};
 pub use error::{
     BlockError, CheckBlockError, CheckBlockTransactionsError, DbCommittingContext,
     InitializationError, OrphanCheckError, StorageCompatibilityCheckError,

chainstate/src/lib.rs

@@ -39,9 +39,9 @@ pub use crate::{
     detail::{
         BlockError, BlockProcessingErrorClass, BlockProcessingErrorClassification, BlockSource,
         ChainInfo, CheckBlockError, CheckBlockTransactionsError, ConnectTransactionError,
-        IOPolicyError, InitializationError, Locator, MEDIAN_TIME_SPAN, NonZeroPoolBalances,
-        OrphanCheckError, SpendStakeError, StorageCompatibilityCheckError, TokenIssuanceError,
-        TokensError, TransactionVerifierStorageError, ban_score,
+        EpochSealError, IOPolicyError, InitializationError, Locator, MEDIAN_TIME_SPAN,
+        NonZeroPoolBalances, OrphanCheckError, SpendStakeError, StorageCompatibilityCheckError,
+        TokenIssuanceError, TokensError, TransactionVerifierStorageError, ban_score,
         block_invalidation::BlockInvalidatorError, bootstrap::BootstrapError,
         calculate_median_time_past, calculate_median_time_past_from_blocktimestamps,
     },