Fix clippy errors. Minor cleanup in run_extra_checks.sh

Author: ImplOfAnImpl

clippy.toml

@@ -0,0 +1,3 @@
+# Clippy will complain if objects smaller that this are boxed.
+# The default is 200 and we sometimes box slightly smaller objects.
+too-large-for-stack = 150

crates/app-core/src/lib.rs

@@ -344,8 +344,7 @@ fn handle_command(cmd: &Command, ctx: &mut AppContext) -> Result<Response, Statu
                     Some(DataContext::SignMessageContext(ctx)) => ctx,
                     _ => return Err(StatusWord::WrongContext),
                 };
-                let response = handle_sign_message(data, msg_ctx).map(Response::MessageSignature);
-                response
+                handle_sign_message(data, msg_ctx).map(Response::MessageSignature)
             }
         },
         Command::Ping => Ok(Response::Pong),

crates/messages/src/lib.rs

@@ -340,7 +340,7 @@ impl<'a> Apdu<'a> {
         param1_byte: u8,
         command_data: &'a [u8],
     ) -> Option<Self> {
-        (command_data.len() <= MAX_ADPU_DATA_LEN).then(|| Self {
+        (command_data.len() <= MAX_ADPU_DATA_LEN).then_some(Self {
             instruction_byte,
             param1_byte,
             command_data,

run_extra_checks.sh

@@ -5,14 +5,23 @@ set -o nounset
 
 # Run some extra checks (for now its mostly clippy).
 
+# Notes about clippy:
+# 1. Ledger's guideline enforcer also runs it. But at the moment of writing this it doesn't check
+#    tests, see https://github.com/LedgerHQ/ledger-app-workflows/blob/master/scripts/check_all.sh.
+#    Besides, we want to enable some additional checks, similar to what we do in Mintlayer Core,
+#    so we do a separate clippy run here.
+# 2. The guideline enforcer runs it for all existing device models, but in this additional run this
+#    is redundant, so we use one arbitrarily chosen model.
+# 3. Unlike in Mintlayer Core, we can't disable certain annoying and mostly useless checks (such as
+#    let-and-return), because the guideline enforcer will run them anyway.
+
 SCRIPT_DIR=$(cd "$(dirname "$0")" && pwd)
 
 cd "$SCRIPT_DIR"
 
 echo "Running cargo fmt"
 cargo fmt --check -- --config newline_style=Unix
 
-# It doesn't matter which one we use, but we need to specify one.
 CLIPPY_TARGET_ARG=--target=apex_p
 
 echo "Running clippy (any code)"
@@ -23,10 +32,7 @@ cargo clippy "$CLIPPY_TARGET_ARG" --all-features --workspace --bins --lib --test
     -D clippy::map_unwrap_or \
     -D clippy::unnested_or_patterns \
     -D clippy::mut_mut \
-    -D clippy::todo \
-    -A clippy::let-and-return \
-    -A clippy::unnecessary-lazy-evaluations \
-    -A clippy::boxed-local
+    -D clippy::todo
 
 echo "Running clippy (production code)"
 # TODO: consider also enabling `unwrap_used` and `items_after_statements`.