App cleanup#9
Draft
ImplOfAnImpl wants to merge 40 commits into
Draft
Conversation
… thinks they're bindings not constants)
…ast output (tests not updated)
…sig); 2) remove unused utils, move Transaction to mintlayer_utils; 3) Transaction now contains unencoded data; 4) tx sig check now expects the proper number of signatures and also checks the returned indices.
…e cleanup; 3) add tx signing tests with large output/input/commitment.
…ning; minor cleanup
…tion instructions
… when encoding into a hasher.
…(test rename); replace the last step with navigate_until_text_and_compare and call it for non-nano devices too
ImplOfAnImpl
force-pushed
the
app_cleanup
branch
from
d832460 to
929b3b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.