Skip to content

Commit bc651b8

Browse files
todinovtodinov
committed
test: add missing assertions
1 parent ad59326 commit bc651b8

4 files changed

Lines changed: 67 additions & 11 deletions

File tree

‎test/test-authentication.js‎

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ describe("Client _getPass1", function () {
4040
client._getPass1({}, "1234", ["oidc"], [], [], function (err, data) {
4141
expect(err).to.exist;
4242
expect(err.message).to.equal("Cryptography error: -14");
43+
expect(data).to.be.null;
4344
done();
4445
});
4546
});
@@ -49,6 +50,8 @@ describe("Client _getPass1", function () {
4950
sinon.stub(client.crypto, "calculatePass1").returns({U: "", UT: ""});
5051

5152
client._getPass1({}, "1234", ["dvs-auth"], [], [], function (err, data) {
53+
expect(err).to.be.null;
54+
expect(data).to.deep.equal({ success: true });
5255
expect(requestStub.firstCall.args[0].data.scope).to.deep.equal(["dvs-auth"]);
5356
done();
5457
});
@@ -97,6 +100,7 @@ describe("Client _getPass2", function () {
97100
client._getPass2({}, ["oidc"], "yHex", [], [], function (err, data) {
98101
expect(err).to.exist;
99102
expect(err.message).to.equal("Cryptography error");
103+
expect(data).to.be.null;
100104
done();
101105
});
102106
});
@@ -119,6 +123,7 @@ describe("Client _finishAuthentication", function () {
119123

120124
client._finishAuthentication("test@example.com", 1234, ["oidc"], "authOTT", function (err, data) {
121125
expect(err).to.exist;
126+
expect(data).to.deep.equal({ status: 400 });
122127
done();
123128
});
124129
});
@@ -268,10 +273,11 @@ describe("Client _authentication", function () {
268273
it("should go through the authentication flow", function (done) {
269274
var getPass1Stub = sinon.stub(client, "_getPass1").yields(null, {});
270275
var getPass2Stub = sinon.stub(client, "_getPass2").yields(null, {});
271-
var finishAuthenticationStub = sinon.stub(client, "_finishAuthentication").yields(null, true);
276+
var finishAuthenticationStub = sinon.stub(client, "_finishAuthentication").yields(null, { success: true });
272277

273278
client._authentication("test@example.com", "1234", ['oidc'], function (err, data) {
274279
expect(err).to.be.null;
280+
expect(data).to.deep.equal({ success: true });
275281
expect(getPass1Stub.calledOnce).to.be.true;
276282
expect(getPass2Stub.calledOnce).to.be.true;
277283
expect(finishAuthenticationStub.calledOnce).to.be.true;
@@ -284,6 +290,7 @@ describe("Client _authentication", function () {
284290

285291
client._authentication("test@example.com", "1234", ['oidc'], function (err, data) {
286292
expect(err).to.exist;
293+
expect(data).to.be.null;
287294
done();
288295
});
289296
});
@@ -294,6 +301,7 @@ describe("Client _authentication", function () {
294301
client._authentication("test@example.com", "1234", ['oidc'], function (err, data) {
295302
expect(err).to.exist;
296303
expect(err.message).to.equal("Revoked");
304+
expect(data).to.be.null;
297305
done();
298306
});
299307
});
@@ -303,6 +311,7 @@ describe("Client _authentication", function () {
303311

304312
client._authentication("test@example.com", "1234", ['oidc'], function (err, data) {
305313
expect(err).to.exist;
314+
expect(data).to.be.null;
306315
done();
307316
});
308317
});
@@ -313,6 +322,7 @@ describe("Client _authentication", function () {
313322

314323
client._authentication("test@example.com", "1234", ['oidc'], function (err, data) {
315324
expect(err).to.exist;
325+
expect(data).to.be.null;
316326
done();
317327
});
318328
});
@@ -340,6 +350,7 @@ describe("Client _authentication", function () {
340350
client._authentication("test@example.com", "1234", ["jwt"], function (err, data) {
341351
expect(err).to.exist;
342352
expect(err.message).to.equal("Authentication fail");
353+
expect(data).to.be.null;
343354
done();
344355
});
345356
});
@@ -354,6 +365,7 @@ describe("Client _authentication", function () {
354365
client._authentication("test@example.com", "1234", ["jwt"], function (err, data) {
355366
expect(err).to.exist;
356367
expect(err.message).to.equal("Unsuccessful authentication");
368+
expect(data).to.be.null;
357369
done();
358370
});
359371
});
@@ -370,6 +382,7 @@ describe("Client _authentication", function () {
370382
client._authentication("test@example.com", "1234", ["jwt"], function (err, data) {
371383
expect(err).to.exist;
372384
expect(err.message).to.equal("Revoked");
385+
expect(data).to.be.null;
373386
expect(userWriteSpy.calledOnce).to.be.true;
374387
expect(userWriteSpy.firstCall.args[0]).to.equal("test@example.com");
375388
expect(userWriteSpy.firstCall.args[1].state).to.equal("REVOKED");
@@ -504,6 +517,7 @@ describe("Client authenticateWithNotificationPayload", function () {
504517
client.authenticateWithNotificationPayload({qrURL: "https://example.com/mobile/auth#accessID"}, "1234", function (err, data) {
505518
expect(err).to.exist;
506519
expect(err.message).to.equal("Invalid push notification payload");
520+
expect(data).to.be.null;
507521
done();
508522
});
509523
});
@@ -512,6 +526,7 @@ describe("Client authenticateWithNotificationPayload", function () {
512526
client.authenticateWithNotificationPayload({userID: "test@example.com"}, "1234", function (err, data) {
513527
expect(err).to.exist;
514528
expect(err.message).to.equal("Invalid push notification payload");
529+
expect(data).to.be.null;
515530
done();
516531
});
517532
});
@@ -554,6 +569,7 @@ describe("Client generateQuickCode", function () {
554569
client.generateQuickCode("test@example.com", "1234", function (err, data) {
555570
expect(err).to.exist;
556571
expect(err.message).to.equal("Authentication fail");
572+
expect(data).to.be.null;
557573
done();
558574
});
559575
});
@@ -565,6 +581,7 @@ describe("Client generateQuickCode", function () {
565581
client.generateQuickCode("test@example.com", "1234", function (err, data) {
566582
expect(err).to.exist;
567583
expect(err.message).to.equal("Request error");
584+
expect(data).to.be.null;
568585
done();
569586
});
570587
});

‎test/test-client.js‎

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,25 +110,28 @@ describe("Client fetchAccessId", function () {
110110
});
111111

112112
it("should make a request for access ID", function () {
113-
var requestStub = sinon.stub(client.http, "request").yields(null, sessionInfo);
113+
sinon.stub(client.http, "request").yields(null, sessionInfo);
114114

115115
client.fetchAccessId("test@example.com", function (err, data) {
116116
expect(data).to.deep.equal(sessionInfo);
117117
});
118118
});
119119

120120
it("should fail when request fails", function () {
121-
var requestStub = sinon.stub(client.http, "request").yields(new Error("Error"), null);
121+
sinon.stub(client.http, "request").yields(new Error("Error"), null);
122122

123123
client.fetchAccessId("test@example.com", function (err, data) {
124124
expect(err).to.exist;
125+
expect(data).to.be.null;
125126
});
126127
});
127128

128129
it("should store session info", function () {
129-
var requestStub = sinon.stub(client.http, "request").yields(null, sessionInfo);
130+
sinon.stub(client.http, "request").yields(null, sessionInfo);
130131

131132
client.fetchAccessId("test@example.com", function (err, data) {
133+
expect(err).to.be.null;
134+
expect(data).to.deep.equal(sessionInfo);
132135
expect(client.session).to.deep.equal(sessionInfo);
133136
});
134137
});
@@ -137,6 +140,8 @@ describe("Client fetchAccessId", function () {
137140
var requestStub = sinon.stub(client.http, "request").yields(null, sessionInfo);
138141

139142
client.fetchAccessId("test@example.com", function (err, data) {
143+
expect(err).to.be.null;
144+
expect(data).to.deep.equal(sessionInfo);
140145
expect(client.session.accessId).to.equal("accessID");
141146
});
142147
});
@@ -166,6 +171,7 @@ describe("Client fetchStatus", function() {
166171

167172
client.fetchStatus(function (err, data) {
168173
expect(err).to.exist;
174+
expect(data).to.be.null;
169175
});
170176
});
171177

@@ -200,6 +206,7 @@ describe("Client sendPushNotificationForAuth", function () {
200206

201207
client.sendPushNotificationForAuth("test@example.com", function (err, data) {
202208
expect(err).to.exist;
209+
expect(data).to.be.null;
203210
});
204211
});
205212

@@ -209,12 +216,14 @@ describe("Client sendPushNotificationForAuth", function () {
209216
client.sendPushNotificationForAuth("test@example.com", function (err, data) {
210217
expect(err).to.exist;
211218
expect(err.message).to.equal("No push token");
219+
expect(data).to.be.null;
212220
});
213221
});
214222

215223
it("should return an error without an user ID", function () {
216224
client.sendPushNotificationForAuth(null, function (err, data) {
217225
expect(err).to.exist;
226+
expect(data).to.be.null;
218227
});
219228
});
220229

‎test/test-dvs.js‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ describe("Client sign", function () {
1919
client.sign("", "1234", "message", "timestamp", function (err, result) {
2020
expect(err).to.exist;
2121
expect(err.message).to.equal("Empty user ID");
22+
expect(result).to.be.null;
2223
done();
2324
});
2425
});
@@ -27,6 +28,7 @@ describe("Client sign", function () {
2728
client.sign("test@example.com", "1234", "", "timestamp", function (err, result) {
2829
expect(err).to.exist;
2930
expect(err.message).to.equal("Empty message");
31+
expect(result).to.be.null;
3032
done();
3133
});
3234
});
@@ -35,6 +37,7 @@ describe("Client sign", function () {
3537
client.sign("missing@example.com", "1234", "message", "timestamp", function (err, result) {
3638
expect(err).to.exist;
3739
expect(err.message).to.equal("User not found");
40+
expect(result).to.be.null;
3841
done();
3942
});
4043
});
@@ -48,6 +51,7 @@ describe("Client sign", function () {
4851
client.sign("nopublickey@example.com", "1234", "message", "timestamp", function (err, result) {
4952
expect(err).to.exist;
5053
expect(err.message).to.equal("Empty public key");
54+
expect(result).to.be.null;
5155
done();
5256
});
5357
});
@@ -72,6 +76,7 @@ describe("Client sign", function () {
7276
expect(err).to.exist;
7377
expect(err.message).to.equal("Signing fail");
7478
expect(err.cause.message).to.equal("Request error");
79+
expect(result).to.be.null;
7580
done();
7681
});
7782
});
@@ -83,6 +88,7 @@ describe("Client sign", function () {
8388
client.sign("test@example.com", "1234", "message", "timestamp", function (err, result) {
8489
expect(err).to.exist;
8590
expect(err.message).to.equal("Unsuccessful authentication");
91+
expect(result).to.be.null;
8692
done();
8793
});
8894
});
@@ -94,6 +100,7 @@ describe("Client sign", function () {
94100
client.sign("test@example.com", "1234", "message", "timestamp", function (err, result) {
95101
expect(err).to.exist;
96102
expect(err.message).to.equal("Revoked");
103+
expect(result).to.be.null;
97104
done();
98105
});
99106
});
@@ -106,6 +113,7 @@ describe("Client sign", function () {
106113
expect(err).to.exist;
107114
expect(err.message).to.equal("Signing fail");
108115
expect(err.cause.message).to.equal("Cryptography error");
116+
expect(result).to.be.null;
109117
done();
110118
});
111119
});

0 commit comments

Comments
 (0)