Commit cb9dcf1
miranov25
Phase 13.17.DF v1.0: documentation refresh
- docs/README.md: full rewrite (883 lines, was 710) reflecting Phase 13.12-13.16
features. New sections: 'What's New in Phase 13.16.DF', 'Multi-Plot Overlays
(same=True)', 'Vector Expressions', 'Auto-Title'. Mode 2 (AliasDataFrame)
rewritten per ADF team Q&A with aDF.draw() as primary API and vector form
recommended for multi-series. Mode 3 (RDataFrameDSL) revised to prefer vector
syntax for multi-series overlays. Toolkit architecture table updated with
RootInteractive status per architect Q&A. Expression Syntax table extended
with bracket-vector rows. API table includes vector_style, group_style,
auto_title, same parameters. Test file list updated (19 files, all verified
against git ls-files). Test count 310 -> 451. Dead references removed
(dfdraw_README.md, dfdraw_api_summary.md, test_facet.py).
- examples/generate_gallery.py: full rewrite (600 lines) with 10 ALICE-flavored
examples covering the full feature set. Per-example reproducible seeds.
Example 08 is the vector-expression ITS centerpiece — two-panel figure
showing the AD-37 bug reproduction (left: scalar loop with fresh DFDraw per
call, 2 colors for 6 layers) alongside the Phase 13.16.DF fix (right: vector
expression in a single call, 6 distinct colors). ALICE data generators
(TPC tracks, ITS residuals, pulls) with physically-plausible distributions.
Executed cleanly in production environment (10/10 figures generated).
- examples/dfdraw_gallery.ipynb: new Jupyter notebook (27 cells) mirroring
generate_gallery.py 1:1 with markdown commentary per example. Self-contained
cells for experimentation. CI-testable via pytest-nbmake or nbconvert.
Example 08 has extra markdown explaining the expected AD-37 before/after
visual. Architect-confirmed to execute cleanly.
- docs/dfdraw_PLOTTING_LIBRARY_COMPARISON.md: light refresh (342 lines,
was 301). Added Phase 13.12-13.16 feature capabilities to ROOT TTree::Draw
'What to Keep' table (auto-title, same=True, vector expressions, batch QA).
Added new rows to Plot Types comparison matrix. Phase 2 renamed, Phase 2b
added for Interactive Features (Phase 13.12-13.16.DF) with 8 sub-items.
Phase 3 Backend Abstraction and Phase 4 RootInteractive Integration
checklists updated per architect Q&A (HistoNdCDS done, HTML export done
in RootInteractive but not wired to dfdraw, bridge module not started).
Current Status Summary updated (451 tests, 43 features, 21 invariance).
Revision history entry 1.2. Strategic/architectural content preserved
verbatim from v1.1.
- docs/examples/*.png: 10 generated ALICE-flavored gallery figures (source of
truth is generate_gallery.py).
Repository hygiene:
- Removed root-level dfdraw_Technical_Summary.md (duplicate of docs/ version;
current canonical location is docs/dfdraw_Technical_Summary.md as of
Phase 13.16.DF).
- Moved dfdraw_PLOTTING_LIBRARY_COMPARISON.md into docs/ (was at project root).
Governance:
- First application of 'doc-only phase' lightweight gate pattern per Org v1.25
§ Phase Lifecycle (justified in proposal §5.2: content derived from already-
reviewed authoritative Phase 13.16.DF docs + ADF/RootInteractive team Q&A).
- Single reviewer: Claude40 (author self-check). Independent cross-check:
Claude42 (non-author, per proposal review Group F). Architect visual
confirmation pre-review: gallery figures verified, notebook execution
verified, text reasonableness confirmed.
- Q&A-driven cross-team content: ADF team Q&A served as source-of-truth for
README Mode 2 content with per-question traceability. RootInteractive team
Q&A informed toolkit architecture table and PLOTTING_LIBRARY_COMPARISON
Phase 4 status.
Deferred to follow-up (not blocking):
- docs/API_REFERENCE.md: 8 small clarity patches (4 GPT5 P1 items from
Phase 13.16.DF documentation review + 4 Claude42 D-P2 items from
Phase 13.16.DF documentation review). Tracked as Phase 13.17.1.DF or
rolled into next doc-touch phase.
- ADF-side persistent DFDraw cache for scalar same=True loops (architect is
considering; suggested future phase: Phase 13.13.ADF v1.0).
- MTTU codification of doc-only phase lightweight gate pattern.
Approved by:
- PHASE_13_17_DF_v1_0_Proposal_DocumentationRefresh.md (5 of 5 reviewers)
- PHASE_13_17_DF_v1_0_PROPOSAL_REVIEW_SUMMARY.md
- PHASE_13_17_DF_v1_0_CODE_REVIEW_REQUEST.md (this document)
Prior phase: PHASE_13_16_DF_v1_0_END1 parent 361d007 commit cb9dcf1
13 files changed
Lines changed: 1459 additions & 175 deletions
File tree
- UTILS/dfextensions/dfdraw
- docs
- examples
- examples
Lines changed: 62 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
13 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
14 | 19 | | |
15 | 20 | | |
16 | 21 | | |
| |||
62 | 67 | | |
63 | 68 | | |
64 | 69 | | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
65 | 74 | | |
66 | 75 | | |
67 | 76 | | |
| |||
108 | 117 | | |
109 | 118 | | |
110 | 119 | | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
111 | 123 | | |
112 | 124 | | |
113 | 125 | | |
| |||
204 | 216 | | |
205 | 217 | | |
206 | 218 | | |
207 | | - | |
| 219 | + | |
208 | 220 | | |
209 | 221 | | |
210 | | - | |
| 222 | + | |
211 | 223 | | |
212 | 224 | | |
213 | 225 | | |
| |||
222 | 234 | | |
223 | 235 | | |
224 | 236 | | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
231 | 269 | | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
| 270 | + | |
237 | 271 | | |
238 | 272 | | |
239 | 273 | | |
240 | 274 | | |
241 | 275 | | |
242 | | - | |
| 276 | + | |
243 | 277 | | |
244 | 278 | | |
245 | 279 | | |
246 | 280 | | |
247 | | - | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
248 | 285 | | |
249 | 286 | | |
250 | | - | |
251 | | - | |
| 287 | + | |
| 288 | + | |
252 | 289 | | |
253 | 290 | | |
254 | 291 | | |
| |||
259 | 296 | | |
260 | 297 | | |
261 | 298 | | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
262 | 302 | | |
263 | 303 | | |
264 | 304 | | |
| |||
299 | 339 | | |
300 | 340 | | |
301 | 341 | | |
| 342 | + | |
0 commit comments