Add Decimal and NumberPunctuation keyboard types#39
Merged
Conversation
MacTHEgenius
approved these changes
Jun 3, 2026
There was a problem hiding this comment.
Pull request overview
Adds two new PilotKeyboardType values (Decimal and NumberPunctuation) to expand the set of platform keyboard hints available to PilotTextField consumers, with corresponding iOS and Android/Compose mappings.
Changes:
- Introduces
DecimalandNumberPunctuationin the sharedPilotKeyboardTypeenum. - Maps
Decimal/NumberPunctuationto the closest available keyboard types on iOS (.decimalPad,.numbersAndPunctuation). - Adds Android/Compose mappings for the new enum values and updates the public API snapshot.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| components/ios/base/Types/PilotKeyboardType.swift | Adds iOS UIKeyboardType mappings for Decimal and NumberPunctuation. |
| components/common/src/commonMain/kotlin/com/mirego/pilot/components/type/PilotKeyboardType.kt | Extends the shared enum with Decimal and NumberPunctuation. |
| components/common/src/androidMain/kotlin/com/mirego/pilot/components/ui/type/PilotKeyboardType.kt | Adds Compose KeyboardType mappings for the new enum values. |
| components/common/api/components.api | Updates the API snapshot to include the new enum constants. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decimalkeyboard type — maps toKeyboardType.Decimal(Compose) and.decimalPad(iOS)NumberPunctuationkeyboard type — maps toKeyboardType.Phone(Compose, closest match for numbers + symbols) and.numbersAndPunctuation(iOS)