add node-chakracore to CI testing#3087
Open
alexlamsl wants to merge 1 commit intomishoo:masterfrom
Open
Conversation
ad274f1 to
70490f8
Compare
fc31b78 to
6cb75d1
Compare
3447f25 to
8b8e12c
Compare
aba2c53 to
b02cc82
Compare
bbdd4aa to
3b8ac9a
Compare
7e31684 to
706a6b1
Compare
9288cf2 to
7ea9d54
Compare
7d1c0a7 to
b468103
Compare
2c87831 to
18af827
Compare
e5231c5 to
04974ea
Compare
57c7752 to
4833362
Compare
46feb12 to
eab8b17
Compare
a682f68 to
65ddb92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Showstoppers:
vm.runInNewContext()nodejs/node-chakracore#478Object.create(null)nodejs/node-chakracore#508[].push.apply([], a)results in "Out of stack space" nodejs/node-chakracore#521