[3.14] Fix os.posix_spawn() error handling (pythonGH-142532) (python#142582)

miss-islington · johnslavik · web-flow · commit fc40e7dc52c0 · 2025-12-11T17:32:11.000Z
Fix os.posix_spawn() error handling (pythonGH-142532) Consistently use `goto exit;` in `py_posix_spawn()`. (cherry picked from commit 8cfa351) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
@@ -7447,7 +7447,7 @@ py_posix_spawn(int use_posix_spawnp, PyObject *module, path_t *path, PyObject *a
     if (argc < 1) {
         PyErr_Format(PyExc_ValueError,
                      "%s: argv must not be empty", func_name);
-        return NULL;
+        goto exit;
     }
 
     if (!PyMapping_Check(env) && env != Py_None) {

Original file line number	Diff line number	Diff line change
`@@ -7447,7 +7447,7 @@ py_posix_spawn(int use_posix_spawnp, PyObject module, path_t path, PyObject *a`
`7447`	`7447`	`if (argc < 1) {`
`7448`	`7448`	`PyErr_Format(PyExc_ValueError,`
`7449`	`7449`	`"%s: argv must not be empty", func_name);`
`7450`		`- return NULL;`
	`7450`	`+ goto exit;`
`7451`	`7451`	`}`
`7452`	`7452`
`7453`	`7453`	`if (!PyMapping_Check(env) && env != Py_None) {`