Skip to content

Commit f801d1c

Browse files
fix(backend): DBレプリケーションを利用する環境でクエリーが失敗する問題を修正 (#16842)
* fix: DBレプリケーションを利用する環境でクエリーが失敗する問題を修正 (MisskeyIO#1123) * Update Changelog --------- Co-authored-by: あわわわとーにゅ <17376330+u1-liquid@users.noreply.github.com>
1 parent 4270697 commit f801d1c

2 files changed

Lines changed: 3 additions & 64 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
- Fix: DeepL APIのAPIキー指定方式変更に対応
2121
(Cherry-picked from https://github.com/MisskeyIO/misskey/pull/1096)
2222
- 内部実装の変更にて対応可能な更新です。Misskey側の設定方法に変更はありません。
23+
- Fix: DBレプリケーションを利用する環境でクエリーが失敗する問題を修正
24+
(Cherry-picked from https://github.com/MisskeyIO/misskey/pull/1123)
2325

2426
## 2025.11.0
2527

packages/backend/src/models/_.ts

Lines changed: 1 addition & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,9 @@
55

66
import {
77
FindOneOptions,
8-
InsertQueryBuilder,
98
ObjectLiteral,
10-
QueryRunner,
119
Repository,
12-
SelectQueryBuilder,
1310
} from 'typeorm';
14-
import { PostgresConnectionOptions } from 'typeorm/driver/postgres/PostgresConnectionOptions.js';
15-
import { RelationCountLoader } from 'typeorm/query-builder/relation-count/RelationCountLoader.js';
16-
import { RelationIdLoader } from 'typeorm/query-builder/relation-id/RelationIdLoader.js';
17-
import {
18-
RawSqlResultsToEntityTransformer,
19-
} from 'typeorm/query-builder/transformer/RawSqlResultsToEntityTransformer.js';
2011
import { MiAbuseReportNotificationRecipient } from '@/models/AbuseReportNotificationRecipient.js';
2112
import { MiAbuseUserReport } from '@/models/AbuseUserReport.js';
2213
import { MiAccessToken } from '@/models/AccessToken.js';
@@ -96,66 +87,12 @@ import { MiWebhook } from '@/models/Webhook.js';
9687
import type { QueryDeepPartialEntity } from 'typeorm/query-builder/QueryPartialEntity.js';
9788

9889
export interface MiRepository<T extends ObjectLiteral> {
99-
createTableColumnNames(this: Repository<T> & MiRepository<T>): string[];
100-
10190
insertOne(this: Repository<T> & MiRepository<T>, entity: QueryDeepPartialEntity<T>, findOptions?: Pick<FindOneOptions<T>, 'relations'>): Promise<T>;
102-
103-
insertOneImpl(this: Repository<T> & MiRepository<T>, entity: QueryDeepPartialEntity<T>, findOptions?: Pick<FindOneOptions<T>, 'relations'>, queryRunner?: QueryRunner): Promise<T>;
104-
105-
selectAliasColumnNames(this: Repository<T> & MiRepository<T>, queryBuilder: InsertQueryBuilder<T>, builder: SelectQueryBuilder<T>): void;
10691
}
10792

10893
export const miRepository = {
109-
createTableColumnNames() {
110-
return this.metadata.columns.filter(column => column.isSelect && !column.isVirtual).map(column => column.databaseName);
111-
},
11294
async insertOne(entity, findOptions?) {
113-
const opt = this.manager.connection.options as PostgresConnectionOptions;
114-
if (opt.replication) {
115-
const queryRunner = this.manager.connection.createQueryRunner('master');
116-
try {
117-
return this.insertOneImpl(entity, findOptions, queryRunner);
118-
} finally {
119-
await queryRunner.release();
120-
}
121-
} else {
122-
return this.insertOneImpl(entity, findOptions);
123-
}
124-
},
125-
async insertOneImpl(entity, findOptions?, queryRunner?) {
126-
// ---- insert + returningの結果を共通テーブル式(CTE)に保持するクエリを生成 ----
127-
128-
const queryBuilder = this.createQueryBuilder().insert().values(entity);
129-
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
130-
const mainAlias = queryBuilder.expressionMap.mainAlias!;
131-
const name = mainAlias.name;
132-
mainAlias.name = 't';
133-
const columnNames = this.createTableColumnNames();
134-
queryBuilder.returning(columnNames.reduce((a, c) => `${a}, ${queryBuilder.escape(c)}`, '').slice(2));
135-
136-
// ---- 共通テーブル式(CTE)から結果を取得 ----
137-
const builder = this.createQueryBuilder(undefined, queryRunner).addCommonTableExpression(queryBuilder, 'cte', { columnNames });
138-
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
139-
builder.expressionMap.mainAlias!.tablePath = 'cte';
140-
this.selectAliasColumnNames(queryBuilder, builder);
141-
if (findOptions) {
142-
builder.setFindOptions(findOptions);
143-
}
144-
const raw = await builder.execute();
145-
mainAlias.name = name;
146-
const relationId = await new RelationIdLoader(builder.connection, this.queryRunner, builder.expressionMap.relationIdAttributes).load(raw);
147-
const relationCount = await new RelationCountLoader(builder.connection, this.queryRunner, builder.expressionMap.relationCountAttributes).load(raw);
148-
const result = new RawSqlResultsToEntityTransformer(builder.expressionMap, builder.connection.driver, relationId, relationCount, this.queryRunner).transform(raw, mainAlias);
149-
return result[0];
150-
},
151-
selectAliasColumnNames(queryBuilder, builder) {
152-
let selectOrAddSelect = (selection: string, selectionAliasName?: string) => {
153-
selectOrAddSelect = (selection, selectionAliasName) => builder.addSelect(selection, selectionAliasName);
154-
return builder.select(selection, selectionAliasName);
155-
};
156-
for (const columnName of this.createTableColumnNames()) {
157-
selectOrAddSelect(`${builder.alias}.${columnName}`, `${builder.alias}_${columnName}`);
158-
}
95+
return await this.insert(entity).then(x => this.findOneOrFail({ where: x.identifiers[0], ...findOptions }));
15996
},
16097
} satisfies MiRepository<ObjectLiteral>;
16198

0 commit comments

Comments
 (0)