Skip to content

enhance(frontend): 添付画像のサムネイルを領域いっぱいに表示できるように#17256

Open
kakkokari-gtyih wants to merge 6 commits intomisskey-dev:developfrom
kakkokari-gtyih:enh-media-list-cover
Open

enhance(frontend): 添付画像のサムネイルを領域いっぱいに表示できるように#17256
kakkokari-gtyih wants to merge 6 commits intomisskey-dev:developfrom
kakkokari-gtyih:enh-media-list-cover

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

What

デフォルトオフ

添付画像のサムネイルを、領域に対してcontainではなくcoverして表示できるようにするオプション

Why

縦横比の関係で実際の領域より小さく表示されてしまうのが不便な人向け

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 21, 2026
@github-actions github-actions Bot added the packages/frontend Client side specific issue/PR label Mar 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 21, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 14.72%. Comparing base (5cb3a91) to head (c670f3a).
⚠️ Report is 70 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/components/MkMediaList.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17256       +/-   ##
============================================
- Coverage    63.79%   14.72%   -49.07%     
============================================
  Files         1162      242      -920     
  Lines       116402    11795   -104607     
  Branches      8446     3980     -4466     
============================================
- Hits         74259     1737    -72522     
+ Misses       39944     7900    -32044     
+ Partials      2199     2158       -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@syuilo
Copy link
Copy Markdown
Member

syuilo commented Mar 23, 2026

/preview

@syuilo
Copy link
Copy Markdown
Member

syuilo commented Apr 7, 2026

/preview

@syuilo
Copy link
Copy Markdown
Member

syuilo commented Apr 7, 2026

頻繁に変えるものではなさそうだから非リアクティブな参照でも良さそうな気はするわね

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

頻繁に変えるものではなさそうだから非リアクティブな参照でも良さそうな気はするわね

ノート系の設定が(何故か)リアクティブが使われている箇所が多かったので倣った

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/frontend Client side specific issue/PR size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

2 participants