fix: move users/notify/list to following/list#17416
Merged
Merged
Conversation
dosubot
Bot
added
the
size:L
github-actions
Bot
added
packages/frontend
Contributor
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -48471,6 +48471,181 @@
}
}
},
+ "/following/list": {
+ "post": {
+ "operationId": "post___following___list",
+ "summary": "following/list",
+ "description": "List of following users\n\n**Credential required**: *Yes* / **Permission**: *read:following*",
+ "externalDocs": {
+ "description": "Source code",
+ "url": "https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/endpoints/following/list.ts"
+ },
+ "tags": [
+ "users"
+ ],
+ "security": [
+ {
+ "bearerAuth": []
+ }
+ ],
+ "requestBody": {
+ "required": true,
+ "content": {
+ "application/json": {
+ "schema": {
+ "type": "object",
+ "properties": {
+ "notification": {
+ "type": "boolean",
+ "default": false
+ },
+ "sinceId": {
+ "type": "string",
+ "format": "misskey:id"
+ },
+ "untilId": {
+ "type": "string",
+ "format": "misskey:id"
+ },
+ "sinceDate": {
+ "type": "integer"
+ },
+ "untilDate": {
+ "type": "integer"
+ },
+ "limit": {
+ "type": "integer",
+ "minimum": 1,
+ "maximum": 100,
+ "default": 10
+ }
+ }
+ }
+ }
+ }
+ },
+ "responses": {
+ "200": {
+ "description": "OK (with results)",
+ "content": {
+ "application/json": {
+ "schema": {
+ "type": "array",
+ "items": {
+ "$ref": "#/components/schemas/Following"
+ }
+ }
+ }
+ }
+ },
+ "400": {
+ "description": "Client error",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/Error"
+ },
+ "examples": {
+ "INVALID_PARAM": {
+ "value": {
+ "error": {
+ "message": "Invalid param.",
+ "code": "INVALID_PARAM",
+ "id": "3d81ceae-475f-4600-b2a8-2bc116157532"
+ }
+ }
+ }
+ }
+ }
+ }
+ },
+ "401": {
+ "description": "Authentication error",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/Error"
+ },
+ "examples": {
+ "CREDENTIAL_REQUIRED": {
+ "value": {
+ "error": {
+ "message": "Credential required.",
+ "code": "CREDENTIAL_REQUIRED",
+ "id": "1384574d-a912-4b81-8601-c7b1c4085df1"
+ }
+ }
+ }
+ }
+ }
+ }
+ },
+ "403": {
+ "description": "Forbidden error",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/Error"
+ },
+ "examples": {
+ "AUTHENTICATION_FAILED": {
+ "value": {
+ "error": {
+ "message": "Authentication failed. Please ensure your token is correct.",
+ "code": "AUTHENTICATION_FAILED",
+ "id": "b0a7f5f8-dc2f-4171-b91f-de88ad238e14"
+ }
+ }
+ }
+ }
+ }
+ }
+ },
+ "418": {
+ "description": "I'm Ai",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/Error"
+ },
+ "examples": {
+ "I_AM_AI": {
+ "value": {
+ "error": {
+ "message": "You sent a request to Ai-chan, Misskey's showgirl, instead of the server.",
+ "code": "I_AM_AI",
+ "id": "60c46cd1-f23a-46b1-bebe-5d2b73951a84"
+ }
+ }
+ }
+ }
+ }
+ }
+ },
+ "500": {
+ "description": "Internal server error",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/Error"
+ },
+ "examples": {
+ "INTERNAL_ERROR": {
+ "value": {
+ "error": {
+ "message": "Internal error occurred. Please contact us if the error persists.",
+ "code": "INTERNAL_ERROR",
+ "id": "5d37dbcb-891e-41ca-a3d6-e690c97775ac"
+ }
+ }
+ }
+ }
+ }
+ }
+ }
+ }
+ }
+ },
"/following/requests/accept": {
"post": {
"operationId": "post___following___requests___accept",
@@ -85192,177 +85367,6 @@
"INVALID_PARAM": {
"value": {
"error": {
- "message": "Invalid param.",
- "code": "INVALID_PARAM",
- "id": "3d81ceae-475f-4600-b2a8-2bc116157532"
- }
- }
- }
- }
- }
- }
- },
- "401": {
- "description": "Authentication error",
- "content": {
- "application/json": {
- "schema": {
- "$ref": "#/components/schemas/Error"
- },
- "examples": {
- "CREDENTIAL_REQUIRED": {
- "value": {
- "error": {
- "message": "Credential required.",
- "code": "CREDENTIAL_REQUIRED",
- "id": "1384574d-a912-4b81-8601-c7b1c4085df1"
- }
- }
- }
- }
- }
- }
- },
- "403": {
- "description": "Forbidden error",
- "content": {
- "application/json": {
- "schema": {
- "$ref": "#/components/schemas/Error"
- },
- "examples": {
- "AUTHENTICATION_FAILED": {
- "value": {
- "error": {
- "message": "Authentication failed. Please ensure your token is correct.",
- "code": "AUTHENTICATION_FAILED",
- "id": "b0a7f5f8-dc2f-4171-b91f-de88ad238e14"
- }
- }
- }
- }
- }
- }
- },
- "418": {
- "description": "I'm Ai",
- "content": {
- "application/json": {
- "schema": {
- "$ref": "#/components/schemas/Error"
- },
- "examples": {
- "I_AM_AI": {
- "value": {
- "error": {
- "message": "You sent a request to Ai-chan, Misskey's showgirl, instead of the server.",
- "code": "I_AM_AI",
- "id": "60c46cd1-f23a-46b1-bebe-5d2b73951a84"
- }
- }
- }
- }
- }
- }
- },
- "500": {
- "description": "Internal server error",
- "content": {
- "application/json": {
- "schema": {
- "$ref": "#/components/schemas/Error"
- },
- "examples": {
- "INTERNAL_ERROR": {
- "value": {
- "error": {
- "message": "Internal error occurred. Please contact us if the error persists.",
- "code": "INTERNAL_ERROR",
- "id": "5d37dbcb-891e-41ca-a3d6-e690c97775ac"
- }
- }
- }
- }
- }
- }
- }
- }
- }
- },
- "/users/notify/list": {
- "post": {
- "operationId": "post___users___notify___list",
- "summary": "users/notify/list",
- "description": "List of following users with notification enabled.\n\n**Credential required**: *Yes* / **Permission**: *read:following*",
- "externalDocs": {
- "description": "Source code",
- "url": "https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/endpoints/users/notify/list.ts"
- },
- "tags": [
- "users"
- ],
- "security": [
- {
- "bearerAuth": []
- }
- ],
- "requestBody": {
- "required": true,
- "content": {
- "application/json": {
- "schema": {
- "type": "object",
- "properties": {
- "sinceId": {
- "type": "string",
- "format": "misskey:id"
- },
- "untilId": {
- "type": "string",
- "format": "misskey:id"
- },
- "sinceDate": {
- "type": "integer"
- },
- "untilDate": {
- "type": "integer"
- },
- "limit": {
- "type": "integer",
- "minimum": 1,
- "maximum": 100,
- "default": 10
- }
- }
- }
- }
- }
- },
- "responses": {
- "200": {
- "description": "OK (with results)",
- "content": {
- "application/json": {
- "schema": {
- "type": "array",
- "items": {
- "$ref": "#/components/schemas/UserDetailed"
- }
- }
- }
- }
- },
- "400": {
- "description": "Client error",
- "content": {
- "application/json": {
- "schema": {
- "$ref": "#/components/schemas/Error"
- },
- "examples": {
- "INVALID_PARAM": {
- "value": {
- "error": {
"message": "Invalid param.",
"code": "INVALID_PARAM",
"id": "3d81ceae-475f-4600-b2a8-2bc116157532" |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #17416 +/- ##
===========================================
+ Coverage 24.84% 25.14% +0.30%
===========================================
Files 1154 1158 +4
Lines 39296 39545 +249
Branches 10940 10983 +43
===========================================
+ Hits 9762 9945 +183
- Misses 23663 23724 +61
- Partials 5871 5876 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Backend memory usage comparisonBefore GC
After GC
After Request
|
Member
Author
|
テストを破壊してしまっていたので直した |
anatawa12
approved these changes
May 16, 2026
anatawa12
left a comment
anatawa12
left a comment
Member
There was a problem hiding this comment.
実装LGTM。名前空間もfollowing以下で良さそうに思います。
testは non blockers
Member
There was a problem hiding this comment.
non blocker: ページネーションのテストもできたらしたいかも?
Member
|
👍 |
anatawa12
added a commit
to anatawa12/misskey
that referenced
this pull request
May 18, 2026
* [skip ci] Update CHANGELOG.md (prepend template) * enhance(frontend): テーマの適用管理を改善 (misskey-dev#17376) * wip * add test * use themeManager.currentCompiledTheme for obtaining theme variables / reduce getComputedStyle usage * fix * fix: better error handling on theme installation * Update Changelog * chore: remove frontend-shared builds as it is currently working as a stub package * fix: broken lockfile * fix * fix lint * fix * Update CHANGELOG.md * enhance(frontend): MkInputでthrottleできるように & delay設定できるように * fix(frontend): ドライブのファイル更新が即座に反映されない問題の修正 (misskey-dev#17383) * enhance: 絵文字データの参照を自前ライブラリに変更 (misskey-dev#17381) * wip * enhance: 絵文字データの参照を自前ライブラリに変更 * fix * update to v17.0.2 * fix assets handling * fix * update mfm-js * update emoji library * Update COPYING [ci skip] * Update Changelog * Update Changelog * fix: 端末の絵文字にフォールバックできるように * Fix: リスト編集画面におけるユーザー追加時のユーザー選択ダイアログにおいて、自身のアカウントが検索結果の一覧に表示されない問題を修正 (misskey-dev#17386) * fix(frontend): cannot add self to list by selectUser dialog * docs(changelog): update changelog * fix(frontend): デッキのカラムから開いたアンテナ・リストの編集ウィンドウを、"ポップアウト"、"新しいタブで表示"、"リンクをコピー"した場合に誤ったリンクが与えられる問題を修正 (misskey-dev#17384) * fix(frontend): incorrect page link for deck pageWindow * docs(changelog): update changelog * fix(frontend): missing はい/いいえ in base-role 「チャンネルの作成」 header (misskey-dev#17380) * Initial plan * fix(frontend): show base-role value text for channel creation policy Agent-Logs-Url: https://github.com/misskey-dev/misskey/sessions/c4fcb1b7-eb6e-444b-bbdf-9b367bc13544 Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com> * Update changelog [ci skip] * fix --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com> Co-authored-by: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com> * perf: rsa sign on slacc (misskey-dev#17322) * perf: rsa sign on slacc * fix: missing async/await * fix: threadPoolSize is always number Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * test(backend): init slacc in unit setup and await ap-request signing * test(backend): move slacc init to unit testEnvironment * test(backend): delete unused file * docs: update CHANGELOG * docs: fix indent Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * chore: migrate to vitest * fix * fix: fix changelog * chore: regenerate lockfile * docs: changelog --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com> * docs: AI コーディングエージェント共通設定を追加 (misskey-dev#17396) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * Bump version to 2026.5.2-alpha.0 * feat: 投稿通知設定したユーザーをリストで見ることができるように (misskey-dev#17385) * feat: 投稿通知を設定したユーザーをリストで見ることができるように * test(e2e): 投稿通知のテスト追加 * chore: 不必要なコードの削除 * Update CHANGELOG.md * Bump version to 2026.5.2-beta.0 * deps: update dependencies (misskey-dev#17400) * deps: Update Dependencies * run pnpm dedupe * update some major packages * update to pnpm v11 * update systeminformation * fix indent * fix: rollback sharp to 0.33 * update re2 * fix(deps): update dependency sanitize-html to v2.17.4 [security] [ci skip] (misskey-dev#17402) * fix(deps): update dependency sanitize-html to v2.17.4 [security] * fix minimumReleaseAgeExclude --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com> * fix(deps): broken lockfile (misskey-dev#17404) * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CHANGELOG.md * fix: move `users/notify/list` to `following/list` (misskey-dev#17416) * fix: move `users/notify/list` to `following/list` * fix * fix lint * fix test * fix test * fix test title * Bump version to 2026.5.2-beta.1 * fix: add-i18n-keyの記述が間違っていたので修正 (misskey-dev#17418) * Release: 2026.5.2 * [skip ci] Update CHANGELOG.md (prepend template) * Update about-misskey.vue * fix(docker): runnerでのpnpmの依存関係チェックを無効化 (misskey-dev#17425) * fix(docker): runnerでのpnpmの依存関係チェックを無効化 * Update Changelog * update changelog * Bump version to 2026.5.3-alpha.0 * Release: 2026.5.3 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com> Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com> Co-authored-by: 4ster1sk <146138447+4ster1sk@users.noreply.github.com> Co-authored-by: Sayamame-beans <61457993+Sayamame-beans@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Acid Chicken <root@acid-chicken.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: おさむのひと <46447427+samunohito@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
m10i1986
pushed a commit
to foundation0-link/misskey
that referenced
this pull request
May 24, 2026
* fix: move `users/notify/list` to `following/list` * fix * fix lint * fix test * fix test * fix test title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
review fix for 2026.5.2
users/notify/listをfollowing/listに変更Why
#17397 (comment)
Additional info (optional)
Checklist