enhance: Set default Node.js version to v26#17623
Conversation
|
このPRによるapi.jsonの差分 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #17623 +/- ##
===========================================
+ Coverage 24.96% 25.21% +0.25%
===========================================
Files 1162 1163 +1
Lines 39749 39941 +192
Branches 11073 11118 +45
===========================================
+ Hits 9925 10073 +148
- Misses 23888 23927 +39
- Partials 5936 5941 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
22をサポートすることに対するコストは無いと思うから落とすのは今後22非対応の改修を入れることになった折もしくは22がEoLになった時でよさそう |
あるにはある 今のところ node-version と min-node-version の2つでワークフローが回っているけど、node-version を v26 に引き上げ、min-node-versionを据え置き(v22)にすると、 v24 に対するテストが行われないことになる テストの改修で対応できないことはないけど、そうすると今度はテストの完了に時間がかかるようになる |
|
あー |
This comment was marked as resolved.
This comment was marked as resolved.
|
一旦26をサポート対象に入れてからデフォルトバージョン上げるステップを踏まないとworkflowが弾かれそう |
This reverts commit bb4e011.
⚙️ Backend Memory Usage ReportAfter GC
V8 Heap Snapshot Statistics
Head heap snapshot composition%%{init: {"sankey":{"showValues":false,"linkColor":"target","labelStyle":"outlined","nodeAlignment":"center","nodePadding":10,"nodeColors":{"Head":"#888888","code":"#f28e2c","bytecode":"#f28e2c","Other":"#888888","strings":"#e15759","string":"#e15759","jsArrays":"#76b7b2","typedArrays":"#59a14f","systemObjects":"#edc949","otherJsObjects":"#af7aa1","array":"#af7aa1","otherNonJsObjects":"#ff9da7"}}}}%%
sankey-beta
"Head","Code",24.51
"Code","bytecode",8.1
"Code","Other",16.41
"Head","Strings",42.15
"Strings","string",41.58
"Strings","Other",0.57
"Head","JS arrays",4.06
"Head","Typed arrays",0.52
"Head","System objects",2.17
"Head","Other JS objs",26.54
"Other JS objs","array",9.74
"Other JS objs","Other",16.8
"Head","Other non-JS objs",0.04
Download representative V8 heap snapshot (head) Runtime Loaded JS FootprintClick to show
Largest Newly Loaded Modules
|
📦 Frontend Bundle ReportChunk size diff (0 updated, 0 added, 0 removed)No data Startup chunk size (0 updated, 0 added, 0 removed)
Startup chunks are the Vite entry for Bundle Stats
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
👍 |
What
nsfw.js を外部化したことにより v22 でないと動作しないという制約が外れたため、v24, v26のサポートを追加し、26.4.0をデフォルトバージョンに設定。v22のサポートは次回削除
Why
Fix #16944
Close #17100
Close #14705
Additional info (optional)
Checklist