Skip to content

refactor(frontend): フロントエンドのfluent-emojisをemoji-assetsから取ってくるように#17662

Merged
syuilo merged 1 commit into
misskey-dev:developfrom
kakkokari-gtyih:fix-use-emoji-assets-instead-of-copying-manually
Jul 8, 2026
Merged

refactor(frontend): フロントエンドのfluent-emojisをemoji-assetsから取ってくるように#17662
syuilo merged 1 commit into
misskey-dev:developfrom
kakkokari-gtyih:fix-use-emoji-assets-instead-of-copying-manually

Conversation

@kakkokari-gtyih

@kakkokari-gtyih kakkokari-gtyih commented Jul 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What

  • 手動でclient-assetsにコピーされているfluent emojiで、@misskey-dev/emoji-assetsにあるものを使用するように
  • assets内のどこからも参照されていないfluent emojiを削除

※クッキークリッカーのクッキーは、64x64だと小さいので対象外

Why

  • @misskey-dev/emoji-assets は画像サイズが縮小済みのため、転送データを削減できる
    • もとのやつは 256x256 で、emoji-assets のやつは 64x64
    • 最大で 42.6kB → 7.4kB
  • どの絵文字を使用していてどの絵文字を使用していないかの管理をする必要がなくなる
    • 実際管理できておらず、使用されていない絵文字がassetsフォルダに残されていた

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 4, 2026
@github-actions github-actions Bot added the packages/frontend Client side specific issue/PR label Jul 4, 2026
@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.00%. Comparing base (eb2c7ff) to head (a40d331).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #17662      +/-   ##
===========================================
- Coverage    24.89%   15.00%   -9.90%     
===========================================
  Files         1162      248     -914     
  Lines        39744    12402   -27342     
  Branches     11088     4224    -6864     
===========================================
- Hits          9896     1861    -8035     
+ Misses       23897     8239   -15658     
+ Partials      5951     2302    -3649

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

📦 Frontend Bundle Report

Chunk size diff (17 updated, 0 added, 0 removed)
Chunk Before After Δ Δ (%)
(total) 5.8 MB 5.9 MB $\color{orange}{\text{+105 KB}}$ $\color{orange}{\text{+1.8\%}}$
esm ja-JP/aEA5QfpmU-CAMkWa7m.js
8.5 KB 104 KB $\color{orange}{\text{+95 KB}}$ $\color{orange}{\text{+1,116.6\%}}$
common ja-JP/aEA5QfpmU-DUbl29cm2.js
4 KB 15 KB $\color{orange}{\text{+11 KB}}$ $\color{orange}{\text{+272.2\%}}$
src/pages/admin/settings.vue ja-JP/aEA5QfpmU-Dxk77amu.js
34 KB 33 KB $\text{-880 B}$ $\color{green}{\text{-2.6\%}}$
i18n ja-JP/aEA5QfpmU-BTYMVLxU.js
216 KB 216 KB $\text{-343 B}$ $\color{green}{\text{-0.2\%}}$
search-index:admin ja-JP/aEA5QfpmU-ChG8KOlZ.js
25 KB 25 KB $\text{-128 B}$ $\color{green}{\text{-0.5\%}}$
src/_boot_.ts ja-JP/aEA5QfpmU-CS3ty0lm.js
63 KB 63 KB $\text{-44 B}$ $\text{-0.1\%}$
src/pages/settings/sounds.vue ja-JP/aEA5QfpmU-pE7y8OKp.js
7.4 KB 7.4 KB $\text{-18 B}$ $\color{green}{\text{-0.2\%}}$
src/pages/settings/security.vue ja-JP/aEA5QfpmU-cEewWBBQ2.js
12 KB 12 KB $\text{-14 B}$ $\color{green}{\text{-0.1\%}}$
src/pages/settings/emoji-palette.vue ja-JP/aEA5QfpmU-CGwvRbFq2.js
9.4 KB 9.4 KB $\text{-13 B}$ $\color{green}{\text{-0.1\%}}$
src/pages/settings/preferences.vue ja-JP/aEA5QfpmU-Bcr_kACt2.js
49 KB 49 KB $\text{-12 B}$ $\text{-0\%}$
src/pages/settings/plugin.vue ja-JP/aEA5QfpmU-CDwJp5KT2.js
9.6 KB 9.6 KB $\text{-12 B}$ $\color{green}{\text{-0.1\%}}$
src/pages/settings/mute-block.vue ja-JP/aEA5QfpmU-T3rx8Anw2.js
13 KB 13 KB $\text{-9 B}$ $\text{-0.1\%}$
src/pages/settings/privacy.vue ja-JP/aEA5QfpmU-9LfluOkM2.js
14 KB 14 KB $\text{-7 B}$ $\text{-0\%}$
src/pages/settings/account-data.vue ja-JP/aEA5QfpmU-BjshxhDc.js
11 KB 11 KB $\text{-6 B}$ $\text{-0.1\%}$
src/pages/settings/drive.vue ja-JP/aEA5QfpmU-hGS-fYuO2.js
18 KB 18 KB $\text{-5 B}$ $\text{-0\%}$
src/pages/settings/notifications.vue ja-JP/aEA5QfpmU-CjUflV7v2.js
7.8 KB 7.8 KB $\text{-3 B}$ $\text{-0\%}$
src/pages/settings/connect.vue ja-JP/aEA5QfpmU-rVo5zO1Q2.js
4.6 KB 4.6 KB $\text{-3 B}$ $\text{-0.1\%}$
Startup chunk size (3 updated, 0 added, 0 removed)
Chunk Before After Δ Δ (%)
(total) 1.1 MB 1.1 MB $\color{orange}{\text{+10 KB}}$ $\color{orange}{\text{+1\%}}$
common ja-JP/aEA5QfpmU-DUbl29cm2.js
4 KB 15 KB $\color{orange}{\text{+11 KB}}$ $\color{orange}{\text{+272.2\%}}$
i18n ja-JP/aEA5QfpmU-BTYMVLxU.js
216 KB 216 KB $\text{-343 B}$ $\color{green}{\text{-0.2\%}}$
src/_boot_.ts ja-JP/aEA5QfpmU-CS3ty0lm.js
63 KB 63 KB $\text{-44 B}$ $\text{-0.1\%}$
os ja-JP/aEA5QfpmU-uMUV013x.js
466 KB 466 KB 0 B 0%
photoswipe ja-JP/aEA5QfpmU-46O-_VUQ.js
73 KB 73 KB 0 B 0%
runtime-core.esm-bundler ja-JP/aEA5QfpmU-Czp4MR8P.js
50 KB 50 KB 0 B 0%
MkNotification ja-JP/aEA5QfpmU-pAZlv1AB2.js
23 KB 23 KB 0 B 0%
built ja-JP/aEA5QfpmU-7DT8rof3.js
21 KB 21 KB 0 B 0%
reactivity.esm-bundler ja-JP/aEA5QfpmU-CSrO7js8.js
21 KB 21 KB 0 B 0%
store ja-JP/aEA5QfpmU-CZgJiZ28.js
18 KB 18 KB 0 B 0%
runtime-dom.esm-bundler ja-JP/aEA5QfpmU-X7uarTMv.js
17 KB 17 KB 0 B 0%
tinycolor ja-JP/aEA5QfpmU-PEGdpOg42.js
15 KB 15 KB 0 B 0%
achievements ja-JP/aEA5QfpmU-BU_7tYWZ.js
10 KB 10 KB 0 B 0%
widgets ja-JP/aEA5QfpmU-DY8hHdPp.js
9.7 KB 9.7 KB 0 B 0%
theme ja-JP/aEA5QfpmU-DVZI9kSq2.js
8.3 KB 8.3 KB 0 B 0%
MkCustomEmoji ja-JP/aEA5QfpmU-BO6zEzRM2.js
6.5 KB 6.5 KB 0 B 0%
MkAnimBg ja-JP/aEA5QfpmU-CgnFZcnm2.js
4.8 KB 4.8 KB 0 B 0%
MkSwiper ja-JP/aEA5QfpmU-uAGpOytQ2.js
3 KB 3 KB 0 B 0%
navbar ja-JP/aEA5QfpmU-C65Oeq-a.js
2.9 KB 2.9 KB 0 B 0%
MkUrl ja-JP/aEA5QfpmU-BpM6_rpB2.js
2.9 KB 2.9 KB 0 B 0%
MkTabs ja-JP/aEA5QfpmU-DT66Dixm2.js
2.8 KB 2.8 KB 0 B 0%
MkCode ja-JP/aEA5QfpmU-CoVfVDm22.js
2.7 KB 2.7 KB 0 B 0%
lookup ja-JP/aEA5QfpmU-nfhGQbzV2.js
2.3 KB 2.3 KB 0 B 0%
MkSparkle ja-JP/aEA5QfpmU-C8_9V4oq2.js
2.2 KB 2.2 KB 0 B 0%
dist ja-JP/aEA5QfpmU-DH0lBfzW.js
1.8 KB 1.8 KB 0 B 0%
_dark ja-JP/aEA5QfpmU-DfGzfoC32.js
1.8 KB 1.8 KB 0 B 0%
media-proxy ja-JP/aEA5QfpmU-PCuJCgiv.js
1.7 KB 1.7 KB 0 B 0%
_light ja-JP/aEA5QfpmU-D67CB4xl.js
1.7 KB 1.7 KB 0 B 0%
hotkey ja-JP/aEA5QfpmU-CDHS_rjR.js
1.6 KB 1.6 KB 0 B 0%
is-birthday ja-JP/aEA5QfpmU-DM8v_C322.js
1.5 KB 1.5 KB 0 B 0%
MkStickyContainer ja-JP/aEA5QfpmU-CyMdke722.js
1.4 KB 1.4 KB 0 B 0%
config ja-JP/aEA5QfpmU-BooIHWtE.js
1.3 KB 1.3 KB 0 B 0%
preload-helper ja-JP/aEA5QfpmU-DyAp3Zfi.js
1.3 KB 1.3 KB 0 B 0%
MkLoading ja-JP/aEA5QfpmU-CnPn2hpg2.js
1.1 KB 1.1 KB 0 B 0%
MkInfo ja-JP/aEA5QfpmU-B88Oxqi6.js
1 KB 1 KB 0 B 0%
webgl ja-JP/aEA5QfpmU-wb3e_Vqx2.js
1 KB 1 KB 0 B 0%
use-scroll-position-keeper ja-JP/aEA5QfpmU-BSBLvoxW2.js
990 B 990 B 0 B 0%
misskey-api ja-JP/aEA5QfpmU-CCuEQeOo.js
986 B 986 B 0 B 0%
instance ja-JP/aEA5QfpmU-CjcngAED.js
918 B 918 B 0 B 0%
get-note-summary ja-JP/aEA5QfpmU-DoX856N-.js
704 B 704 B 0 B 0%
rolldown-runtime ja-JP/aEA5QfpmU-QTnfLwEv.js
694 B 694 B 0 B 0%
page ja-JP/aEA5QfpmU-Bis5QdHx.js
688 B 688 B 0 B 0%
i ja-JP/aEA5QfpmU-BWSnaHM9.js
631 B 631 B 0 B 0%
clear-cache ja-JP/aEA5QfpmU-B90g5SNj2.js
472 B 472 B 0 B 0%
emoji-base ja-JP/aEA5QfpmU-BVbfT0gI2.js
413 B 413 B 0 B 0%
d-green-lime ja-JP/aEA5QfpmU-DEHvjKGz.js
391 B 391 B 0 B 0%
use-interval ja-JP/aEA5QfpmU-Be0B6Hww.js
384 B 384 B 0 B 0%
l-light ja-JP/aEA5QfpmU-B8GJAiDX.js
351 B 351 B 0 B 0%
user ja-JP/aEA5QfpmU-FJNwJJuw.js
205 B 205 B 0 B 0%
get-bg-color ja-JP/aEA5QfpmU-B6J3wW2j2.js
190 B 190 B 0 B 0%
isChromatic ja-JP/aEA5QfpmU-Dd9satMa2.js
172 B 172 B 0 B 0%
is-device-darkmode ja-JP/aEA5QfpmU-CHGi6RJT2.js
93 B 93 B 0 B 0%
_plugin-vue_export-helper ja-JP/aEA5QfpmU-BDNMzG2s.js
84 B 84 B 0 B 0%

Startup chunks are the Vite entry for src/_boot_.ts and its static imports.

Bundle Stats

Bundles Modules Entries Imports Size
Static Dynamic Rendered Gzip Brotli
Before 466 2,852 21 8,574 323 10 MB 2.8 MB 2.4 MB
After 466 2,851 21 8,574 324 10 MB 2.8 MB 2.4 MB
Δ 0 $\color{green}{\text{-1}}$ 0 0 $\color{orange}{\text{+1}}$ $\color{green}{\text{-1.7 KB}}$ $\text{-437 B}$ $\text{-132 B}$
Δ (%) 0% $\text{-0\%}$ 0% 0% $\color{orange}{\text{+0.3\%}}$ $\text{-0\%}$ $\text{-0\%}$ $\text{-0\%}$

Open treemap HTML

@syuilo

syuilo commented Jul 5, 2026

Copy link
Copy Markdown
Member

/preview

1 similar comment
@syuilo

syuilo commented Jul 8, 2026

Copy link
Copy Markdown
Member

/preview

@syuilo

syuilo commented Jul 8, 2026

Copy link
Copy Markdown
Member

高解像度なディスプレイで見た時に周りと比べて若干鮮明じゃないのは気になるかも

@kakkokari-gtyih

kakkokari-gtyih commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

高解像度なディスプレイで見た時に周りと比べて若干鮮明じゃないのは気になるかも

自分のディスプレイがそこまで高解像度じゃないのでそこまで気にならなかった＋UIアイコンでそこまできれいに表示させる必要はない可能性がある（読み込みの速さを優先すべきかもしれない）

@syuilo

syuilo commented Jul 8, 2026

Copy link
Copy Markdown
Member

ほむん

@syuilo
syuilo merged commit 9440423 into misskey-dev:develop Jul 8, 2026
25 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in [実験中] 管理用 Jul 8, 2026
@syuilo

syuilo commented Jul 8, 2026

Copy link
Copy Markdown
Member

👍🏻

@kakkokari-gtyih
kakkokari-gtyih deleted the fix-use-emoji-assets-instead-of-copying-manually branch July 8, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

packages/frontend Client side specific issue/PR size:S This PR changes 10-29 lines, ignoring generated files.

Projects

[実験中] 管理用
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kakkokari-gtyih @syuilo