feat(dev): frontend browser metrics report (alt - using Playwright)#17684
Draft
kakkokari-gtyih wants to merge 23 commits into
Draft
feat(dev): frontend browser metrics report (alt - using Playwright)#17684kakkokari-gtyih wants to merge 23 commits into
kakkokari-gtyih wants to merge 23 commits into
Conversation
This reverts commit e60e965.
github-actions
Bot
added
packages/frontend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #17684 +/- ##
===========================================
- Coverage 15.00% 13.64% -1.36%
===========================================
Files 248 247 -1
Lines 12402 12213 -189
Branches 4224 4109 -115
===========================================
- Hits 1861 1667 -194
- Misses 8239 8246 +7
+ Partials 2302 2300 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
📦 Frontend Bundle ReportChunk size diff (0 updated, 0 added, 0 removed)No data Startup chunk size (0 updated, 0 added, 0 removed)
Startup chunks are the Vite entry for Bundle Stats
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
Author
|
どこまでを実現したいかはわからないけど多分コードのメンテナンス性で行けばこっちのほうが良い（のと、そのシナリオをそのままテストに使える）ので良い感じに引き継いでいただけるとよいかと思います jsonのサンプル→ https://github.com/misskey-dev/misskey/actions/runs/28942007808/artifacts/8167958278 |
Member
|
メトリクス集計用途だと、それぞれ5回くらいサンプル採りたいからテストと兼ねない方がいいかもしれない(テストは1回だけで問題ない) |
Member
Author
|
いまのところCIでのプロセスがe2eと同じタイミングでやってるのでそこにhead-baseの比較とかを入れると見通しが悪くなりそう（なので結果比較は別のactionでやるべきそう） あとmain branchのほうの結果は毎回e2e実行し直すのはなんかめんどくさい気がするのでコミットハッシュ＋branchか何かで保持して持ってくる（無かったら再テスト回す）ほうが賢そう ノートの投稿まで終わらすところまでのシナリオはもうe2eとして存在してそう |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
各ステップのメモリ使用量（テスト実行前のまっさらのブラウザ → テストひととおり実行後のメモリ使用量）と、ブラウザ内部のメトリクスを全部jsonとして出力するところまでできている
サンプル→ https://github.com/misskey-dev/misskey/actions/runs/28942007808/artifacts/8167958278
Why
Close #17630
Additional info (optional)
Checklist