Merge pull request #266 from ozgursoy/master

slice mapping bug fix

Author: mitchellh

mapstructure.go

@@ -1123,6 +1123,8 @@ func (d *Decoder) decodeSlice(name string, data interface{}, val reflect.Value)
 	if valSlice.IsNil() || d.config.ZeroFields {
 		// Make a new slice to hold our result, same size as the original data.
 		valSlice = reflect.MakeSlice(sliceType, dataVal.Len(), dataVal.Len())
+	} else if valSlice.Len() > dataVal.Len() {
+		valSlice = valSlice.Slice(0, dataVal.Len())
 	}
 
 	// Accumulate any errors

mapstructure_test.go

@@ -138,6 +138,11 @@ type Slice struct {
 	Vbar []string
 }
 
+type SliceOfByte struct {
+	Vfoo string
+	Vbar []byte
+}
+
 type SliceOfAlias struct {
 	Vfoo string
 	Vbar SliceAlias
@@ -1654,6 +1659,34 @@ func TestSlice(t *testing.T) {
 	testSliceInput(t, inputStringSlicePointer, outputStringSlice)
 }
 
+func TestNotEmptyByteSlice(t *testing.T) {
+	t.Parallel()
+
+	inputByteSlice := map[string]interface{}{
+		"vfoo": "foo",
+		"vbar": []byte(`{"bar": "bar"}`),
+	}
+
+	result := SliceOfByte{
+		Vfoo: "another foo",
+		Vbar: []byte(`{"bar": "bar bar bar bar bar bar bar bar"}`),
+	}
+
+	err := Decode(inputByteSlice, &result)
+	if err != nil {
+		t.Fatalf("got unexpected error: %s", err)
+	}
+
+	expected := SliceOfByte{
+		Vfoo: "foo",
+		Vbar: []byte(`{"bar": "bar"}`),
+	}
+
+	if !reflect.DeepEqual(result, expected) {
+		t.Errorf("bad: %#v", result)
+	}
+}
+
 func TestInvalidSlice(t *testing.T) {
 	t.Parallel()