StringToSlice: empty string is empty slice

mitchellh · mitchellh · commit 6fb2c832bcac · 2014-05-06T18:46:58.000-07:00
diff --git a/decode_hooks.go b/decode_hooks.go
@@ -43,6 +43,10 @@ func StringToSliceHookFunc(sep string) DecodeHookFunc {
 		}
 
 		raw := data.(string)
+		if raw == "" {
+			return []string{}, nil
+		}
+
 		return strings.Split(raw, sep), nil
 	}
 }
diff --git a/decode_hooks_test.go b/decode_hooks_test.go
@@ -96,6 +96,13 @@ func TestStringToSliceHookFunc(t *testing.T) {
 			[]string{"foo", "bar", "baz"},
 			false,
 		},
+		{
+			reflect.String,
+			reflect.Slice,
+			"",
+			[]string{},
+			false,
+		},
 	}
 
 	for i, tc := range cases {

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,10 @@ func StringToSliceHookFunc(sep string) DecodeHookFunc {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`raw := data.(string)`
	`46`	`+ if raw == "" {`
	`47`	`+ return []string{}, nil`
	`48`	`+ }`
	`49`	`+`
`46`	`50`	`return strings.Split(raw, sep), nil`
`47`	`51`	`}`
`48`	`52`	`}`