Update dependencied and required code to allow running it on new Vagrant#273
Open
ingwarsw wants to merge 3 commits into
Open
Update dependencied and required code to allow running it on new Vagrant#273ingwarsw wants to merge 3 commits into
ingwarsw wants to merge 3 commits into
Conversation
Contributor
Author
|
@Temikus Im not sure if your still maintainer here but would be cool to merge this and release new version of the plugin. |
yeah.. it would be really helpful |
|
Hi, any stops to merging this? I have tested this PR and works fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project to support newer dependencies, modernizes the Ruby version, and introduces a minor feature improvement. The most significant changes are upgrading the
fog-googledependency, updating the supported Ruby version, and adding a new default forresource_policiesin configuration tests.Dependency and compatibility updates:
fog-googlegem dependency to version~> 1.25.0invagrant-google.gemspecto ensure compatibility with newer versions.2.7.4to3.4, and removed the specific Ruby version label in.github/workflows/ci.yml.Code and API adjustments for updated dependencies:
Fog::Compute::Google::*toFog::Google::Compute::*inlib/vagrant-google/action/run_instance.rbandlib/vagrant-google/action/start_instance.rbto match the newfog-googlegem API. [1] [2]Feature and test improvements:
resource_policiesis an empty array intest/unit/common/config_test.rb.Versioning:
2.7.0to2.8.0inlib/vagrant-google/version.rb.