|
1 | 1 | /// YAML value => prettified text |
2 | 2 | use crate::protobuf::view_protobuf::tags; |
3 | 3 | use regex::Captures; |
| 4 | +use std::fmt::{Display, Formatter}; |
| 5 | + |
| 6 | +/// Collect all representations of a number and output the "best" one as the YAML value |
| 7 | +/// and the rest as comments. |
| 8 | +struct NumReprs(Vec<(&'static str, String)>); |
| 9 | + |
| 10 | +impl NumReprs { |
| 11 | + fn new(k: &'static str, v: impl ToString) -> Self { |
| 12 | + let mut inst = Self(Vec::with_capacity(3)); |
| 13 | + inst.push(k, v); |
| 14 | + inst |
| 15 | + } |
| 16 | + fn push(&mut self, k: &'static str, v: impl ToString) { |
| 17 | + self.0.push((k, v.to_string())); |
| 18 | + } |
| 19 | +} |
| 20 | + |
| 21 | +impl Display for NumReprs { |
| 22 | + fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { |
| 23 | + // We first sort by t.len(), which is a hack to make sure that sint is not used |
| 24 | + // as the main representation. |
| 25 | + let (min_typ, min_val) = self |
| 26 | + .0 |
| 27 | + .iter() |
| 28 | + .min_by_key(|(t, v)| (t.len(), v.len())) |
| 29 | + .unwrap(); |
| 30 | + let mut i = self.0.iter().filter(|(t, _)| t != min_typ); |
| 31 | + |
| 32 | + write!(f, "{}", min_val)?; |
| 33 | + if let Some((t, v)) = i.next() { |
| 34 | + write!(f, " # {}: {}", t, v)?; |
| 35 | + } |
| 36 | + for (t, v) in i { |
| 37 | + write!(f, ", {}: {}", t, v)?; |
| 38 | + } |
| 39 | + Ok(()) |
| 40 | + } |
| 41 | +} |
4 | 42 |
|
5 | 43 | // Helper method to apply regex replacements to the YAML output |
6 | 44 | pub(super) fn apply_replacements(yaml_str: &str) -> anyhow::Result<String> { |
7 | 45 | // Replace !fixed32 tags with comments showing float and i32 interpretations |
8 | 46 | let with_fixed32 = tags::FIXED32_RE.replace_all(yaml_str, |caps: &Captures| { |
9 | 47 | let value = caps[1].parse::<u32>().unwrap_or_default(); |
| 48 | + let mut repr = NumReprs::new("u32", value); |
| 49 | + |
10 | 50 | let float_value = f32::from_bits(value); |
11 | | - let i32_value = value as i32; |
| 51 | + if !float_value.is_nan() { |
| 52 | + let mut float = format!("{}", float_value); |
| 53 | + if !float.contains(".") { |
| 54 | + float.push_str(".0"); |
| 55 | + } |
| 56 | + repr.push("f32", float); |
| 57 | + } |
12 | 58 |
|
13 | | - if !float_value.is_nan() && float_value < 0.0 { |
14 | | - format!( |
15 | | - "{} {} # float: {}, i32: {}", |
16 | | - *tags::FIXED32, |
17 | | - value, |
18 | | - float_value, |
19 | | - i32_value |
20 | | - ) |
21 | | - } else if !float_value.is_nan() { |
22 | | - format!("{} {} # float: {}", *tags::FIXED32, value, float_value) |
23 | | - } else if i32_value < 0 { |
24 | | - format!("{} {} # i32: {}", *tags::FIXED32, value, i32_value) |
25 | | - } else { |
26 | | - format!("{} {}", *tags::FIXED32, value) |
| 59 | + if value.leading_zeros() == 0 { |
| 60 | + repr.push("i32", value as i32); |
27 | 61 | } |
| 62 | + format!("{} {}", *tags::FIXED32, repr) |
28 | 63 | }); |
29 | 64 |
|
30 | 65 | // Replace !fixed64 tags with comments showing double and i64 interpretations |
31 | 66 | let with_fixed64 = tags::FIXED64_RE.replace_all(&with_fixed32, |caps: &Captures| { |
32 | 67 | let value = caps[1].parse::<u64>().unwrap_or_default(); |
| 68 | + let mut repr = NumReprs::new("u64", value); |
| 69 | + |
33 | 70 | let double_value = f64::from_bits(value); |
34 | | - let i64_value = value as i64; |
| 71 | + if !double_value.is_nan() { |
| 72 | + let mut double = format!("{}", double_value); |
| 73 | + if !double.contains(".") { |
| 74 | + double.push_str(".0"); |
| 75 | + } |
| 76 | + repr.push("f64", double); |
| 77 | + } |
35 | 78 |
|
36 | | - if !double_value.is_nan() && double_value < 0.0 { |
37 | | - format!( |
38 | | - "{} {} # double: {}, i64: {}", |
39 | | - *tags::FIXED64, |
40 | | - value, |
41 | | - double_value, |
42 | | - i64_value |
43 | | - ) |
44 | | - } else if !double_value.is_nan() { |
45 | | - format!("{} {} # double: {}", *tags::FIXED64, value, double_value) |
46 | | - } else if i64_value < 0 { |
47 | | - format!("{} {} # i64: {}", *tags::FIXED64, value, i64_value) |
48 | | - } else { |
49 | | - format!("{} {}", *tags::FIXED64, value) |
| 79 | + if value.leading_zeros() == 0 { |
| 80 | + repr.push("i64", value as i64); |
50 | 81 | } |
| 82 | + format!("{} {}", *tags::FIXED64, repr) |
51 | 83 | }); |
52 | 84 |
|
53 | 85 | // Replace !varint tags with comments showing signed interpretation if different |
54 | 86 | let with_varint = tags::VARINT_RE.replace_all(&with_fixed64, |caps: &Captures| { |
55 | | - let unsigned_value = caps[1].parse::<u64>().unwrap_or_default(); |
56 | | - let i64_zigzag = decode_zigzag64(unsigned_value); |
| 87 | + let value = caps[1].parse::<u64>().unwrap_or_default(); |
| 88 | + let mut repr = NumReprs::new("u64", value); |
57 | 89 |
|
58 | | - // Only show signed value if it's different from unsigned |
59 | | - if i64_zigzag < 0 { |
60 | | - format!("{} # signed: {}", unsigned_value, i64_zigzag) |
| 90 | + if value.leading_zeros() == 0 { |
| 91 | + repr.push("i64", value as i64); |
| 92 | + // We only show u64 and i64 reprs if the leading bit is a 1. |
| 93 | + // It could technically be zigzag, but the odds are quite low. |
61 | 94 | } else { |
62 | | - unsigned_value.to_string() |
| 95 | + repr.push("!sint", decode_zigzag64(value)); |
63 | 96 | } |
| 97 | + |
| 98 | + repr.to_string() |
64 | 99 | }); |
65 | 100 |
|
66 | 101 | Ok(with_varint.to_string()) |
|
0 commit comments