protobuf view: initial review

Author: mhils

src/contentviews/grpc.rs

@@ -63,7 +63,7 @@ impl Reencode for GRPC {
         let mut ret = vec![];
         for document in serde_yaml::Deserializer::from_str(data) {
             let value = Value::deserialize(document).context("Invalid YAML")?;
-            let proto = Protobuf::reencode_yaml(value, metadata)?;
+            let proto = super::protobuf::reencode::reencode_yaml(value, metadata)?;
             ret.push(0); // compressed
             ret.extend(u32::to_be_bytes(proto.len() as u32));
             ret.extend(proto);
@@ -74,12 +74,9 @@ impl Reencode for GRPC {
 
 #[cfg(test)]
 mod tests {
-    use super::*;
-    use crate::contentviews::TestMetadata;
 
     #[test]
     fn test_grpc() {
-        let result = GRPC.prettify(b"foo", &TestMetadata::default()).unwrap();
-        assert_eq!(result, "666f6f");
+        // FIXME
     }
 }

src/contentviews/mod.rs

@@ -24,15 +24,15 @@ pub trait Prettify: Send + Sync {
         self.name().to_lowercase().replace(" ", "_")
     }
 
+    fn syntax_highlight(&self) -> syntax_highlight::Language {
+        syntax_highlight::Language::None
+    }
+
     fn prettify(&self, data: &[u8], metadata: &dyn Metadata) -> Result<String>;
 
     fn render_priority(&self, _data: &[u8], _metadata: &dyn Metadata) -> f64 {
         0.0
     }
-
-    fn syntax_highlight(&self) -> syntax_highlight::Language {
-        syntax_highlight::Language::None
-    }
 }
 
 pub trait Reencode: Send + Sync {

src/contentviews/msgpack.rs

@@ -130,4 +130,12 @@ tags:
         // Compare the values
         assert_eq!(original_value, result_value);
     }
+
+    #[test]
+    fn test_invalid_yaml() {
+        let err = MsgPack
+            .reencode("@invalid_yaml", &TestMetadata::default())
+            .unwrap_err();
+        assert_eq!(format!("{err}"), "Invalid YAML");
+    }
 }