Skip to content

Fix panic caused by unsupported TIFF format#287

Merged
mhils merged 1 commit intomitmproxy:mainfrom
DNEGEL3125:fix-tiff-panic
Nov 19, 2025
Merged

Fix panic caused by unsupported TIFF format#287
mhils merged 1 commit intomitmproxy:mainfrom
DNEGEL3125:fix-tiff-panic

Conversation

@DNEGEL3125
Copy link
Copy Markdown
Contributor

TIFF sample format IEEEFP is currently not supported by image crate.

Returning an error instead of calling unwrap() allows Python code to catch it.

mitmproxy/tools/web/app.py:

try:
    # called `Result::unwrap()` on an `Err` value: Unsupported(UnsupportedError { format: Exact(Tiff), kind: GenericFeature("Unhandled TIFF sample format IEEEFP") })
    icon_bytes = mitmproxy_rs.process_info.executable_icon(path)
except Exception:
    icon_bytes = TRANSPARENT_PNG

TIFF sample format IEEEFP is currently not supported by `image` crate.

Returning an error instead of calling `unwrap()` allows Python code to catch it.
Copy link
Copy Markdown
Member

@mhils mhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you so much! 😃 🍰

@mhils mhils merged commit 1839bbd into mitmproxy:main Nov 19, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants