Fix panic caused by unsupported TIFF format#287
Merged
mhils merged 1 commit intomitmproxy:mainfrom Nov 19, 2025
Merged
Conversation
TIFF sample format IEEEFP is currently not supported by `image` crate. Returning an error instead of calling `unwrap()` allows Python code to catch it.
mhils
approved these changes
Nov 19, 2025
Member
mhils
left a comment
There was a problem hiding this comment.
Fantastic, thank you so much! 😃 🍰
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TIFF sample format IEEEFP is currently not supported by
imagecrate.Returning an error instead of calling
unwrap()allows Python code to catch it.mitmproxy/tools/web/app.py: