Addressing some feedback

Author: rhysyngsun

load_testing/config.ts

@@ -8,7 +8,9 @@ export const FRONTEND_BASE_URL: string = __ENV.FRONTEND_BASE_URL?.replace(
   /\/$/,
   "",
 )
-export const SSO_BASE_URL: string = __ENV.SSO_BASE_URL?.replace(/\/$/, "")
+export const SSO_BASE_URL: string = (
+  __ENV.SSO_BASE_URL ?? "http://localhost"
+).replace(/\/$/, "")
 
 export const IGNORE_HTTPS_ERRORS: boolean =
   (__ENV.IGNORE_HTTPS_ERRORS || "false").toLowerCase() == "true"

load_testing/frontend/test.ts

@@ -103,7 +103,7 @@ async function loginKeycloak(
   await page.locator("button[type=submit]").click()
   console.log("Login > Keycloak > submitting email address")
 
-  await page.waitForNavigation(KEYCLOAK_PASSWORD_URL_RE)
+  await page.waitForURL(KEYCLOAK_PASSWORD_URL_RE)
   console.log("Login > Keycloak > on login password page")
 
   const passwordInput = await page.locator("input[name=password]")

load_testing/learn.average-load.ts

@@ -39,6 +39,8 @@ export const options = {
   thresholds: {
     // the rate of successful checks should be higher than 90%
     checks: ["rate>0.9"],
+    http_req_failed: ["rate<0.01"],
+    browser_http_req_failed: ["rate<0.05"],
   },
   insecureSkipTLSVerify: IGNORE_HTTPS_ERRORS,
 }

load_testing/learn.smoke.ts

@@ -30,6 +30,8 @@ export const options = {
   thresholds: {
     // the rate of successful checks should be higher than 90%
     checks: ["rate>0.9"],
+    http_req_failed: ["rate<0.01"],
+    browser_http_req_failed: ["rate<0.05"],
   },
   insecureSkipTLSVerify: IGNORE_HTTPS_ERRORS,
 }

load_testing/learn.stress.ts

@@ -39,6 +39,8 @@ export const options = {
   thresholds: {
     // the rate of successful checks should be higher than 90%
     checks: ["rate>0.9"],
+    http_req_failed: ["rate<0.01"],
+    browser_http_req_failed: ["rate<0.05"],
   },
   insecureSkipTLSVerify: IGNORE_HTTPS_ERRORS,
 }