feedback

Author: mbertrand

learning_resources/views.py

@@ -834,7 +834,7 @@ def list(self, request, *args, **kwargs):
         return super().list(request, *args, **kwargs)
 
     def get_serializer_class(self):
-        if self.action == "create":
+        if self.action in {"create", "update", "partial_update"}:
             return LearningPathRelationshipCreateSerializer
         return super().get_serializer_class()
 

learning_resources/views_userlist_test.py

@@ -67,25 +67,13 @@ def test_user_list_endpoint_get(client, user, is_author, has_image, is_unlisted)
 
 
 def test_user_list_endpoint_list_query_count_constant(
-    client, django_assert_num_queries
+    client, django_assert_max_num_queries
 ):
     """User list list queries should not grow with list count."""
     user = UserFactory.create()
     client.force_login(user)
 
-    user_list = factories.UserListFactory.create(author=user)
-    course = factories.CourseFactory.create()
-    UserListRelationship.objects.create(
-        parent=user_list,
-        child=course.learning_resource,
-        position=0,
-    )
-
-    with django_assert_num_queries(5, exact=False):
-        baseline_resp = client.get(reverse("lr:v1:userlists_api-list"))
-    assert baseline_resp.status_code == 200
-
-    for _ in range(4):
+    def _create_list_with_item():
         user_list = factories.UserListFactory.create(author=user)
         course = factories.CourseFactory.create()
         UserListRelationship.objects.create(
@@ -94,7 +82,19 @@ def test_user_list_endpoint_list_query_count_constant(
             position=0,
         )
 
-    with django_assert_num_queries(5, exact=False):
+    _create_list_with_item()
+
+    # Cap well below what an N+1 on topics/children/image would produce
+    # for the expanded case (5 lists with related data).
+    query_budget = 20
+    with django_assert_max_num_queries(query_budget):
+        baseline_resp = client.get(reverse("lr:v1:userlists_api-list"))
+    assert baseline_resp.status_code == 200
+
+    for _ in range(4):
+        _create_list_with_item()
+
+    with django_assert_max_num_queries(query_budget):
         expanded_resp = client.get(reverse("lr:v1:userlists_api-list"))
     assert expanded_resp.status_code == 200