address the feedback

Author: Ahtesham Quraish

news_events/tasks.py

@@ -54,8 +54,11 @@ def get_website_content_news():
     clear_views_cache()
 
 
-# Backward-compatible alias so any queued Celery tasks using the old name still work.
-get_articles_news = get_website_content_news
+@app.task(name="news_events.tasks.get_articles_news")
+def get_articles_news():
+    """Backward-compatible alias for get_website_content_news."""
+    pipelines.articles_news_etl()
+    clear_views_cache()
 
 
 @app.task(
@@ -105,5 +108,11 @@ def sync_website_content_to_news(self, content_id: int):
         raise
 
 
-# Backward-compatible alias so any queued Celery tasks using the old name still work.
-sync_article_to_news = sync_website_content_to_news
+@app.task(
+    name="news_events.tasks.sync_article_to_news",
+    autoretry_for=(Exception,),
+    retry_kwargs={"max_retries": 3, "countdown": 5},
+)
+def sync_article_to_news(article_id: int):
+    """Backward-compatible alias for sync_website_content_to_news."""
+    sync_website_content_to_news.apply(args=[article_id], throw=True)

website_content/constants.py

@@ -2,7 +2,7 @@
 
 from named_enum import ExtendedEnum
 
-GROUP_STAFF_ARTICLE_EDITORS = "article_editors"
+GROUP_WEBSITE_CONTENT_EDITORS = "website_content_editors"
 
 
 class WebsiteContentType(ExtendedEnum):

website_content/migrations/0003_add_editors_group.py

@@ -1,22 +1,29 @@
 """
-Ensure the article_editors Group exists in the database.
+Ensure the website_content_editors Group exists in the database.
 
-Reuses the same group name as the old articles app so that existing users
-already in the group retain their permissions without any manual intervention.
+If the legacy article_editors Group exists, copy its members into the new group
+so existing editors retain access after the rename.
 """
 
-from django.contrib.auth.models import Group
 from django.db import migrations
 
-from website_content.constants import GROUP_STAFF_ARTICLE_EDITORS
+OLD_GROUP_NAME = "article_editors"
+NEW_GROUP_NAME = "website_content_editors"
 
 
-def add_editors_group(apps, schema_editor):  # noqa: ARG001
-    Group.objects.get_or_create(name=GROUP_STAFF_ARTICLE_EDITORS)
+def add_editors_group(apps, schema_editor):
+    Group = apps.get_model("auth", "Group")
 
+    new_group, _ = Group.objects.get_or_create(name=NEW_GROUP_NAME)
+    old_group = Group.objects.filter(name=OLD_GROUP_NAME).first()
 
-def remove_editors_group(apps, schema_editor):  # noqa: ARG001
-    Group.objects.filter(name=GROUP_STAFF_ARTICLE_EDITORS).delete()
+    if old_group and old_group.pk != new_group.pk:
+        new_group.user_set.add(*old_group.user_set.all())
+
+
+def remove_editors_group(apps, schema_editor):
+    Group = apps.get_model("auth", "Group")
+    Group.objects.filter(name=NEW_GROUP_NAME).delete()
 
 
 class Migration(migrations.Migration):

website_content/permissions.py

@@ -1,12 +1,12 @@
 from rest_framework.permissions import SAFE_METHODS, BasePermission
 
 from learning_resources.permissions import is_admin_user
-from website_content.constants import GROUP_STAFF_ARTICLE_EDITORS
+from website_content.constants import GROUP_WEBSITE_CONTENT_EDITORS
 
 
 def is_website_content_editor(request):
     """
-    Return True if the request user belongs to the article_editors group.
+    Return True if the request user belongs to the website_content_editors group.
 
     Args:
         request (HTTPRequest): django request object
@@ -16,7 +16,7 @@ def is_website_content_editor(request):
     """
     return (
         request.user is not None
-        and request.user.groups.filter(name=GROUP_STAFF_ARTICLE_EDITORS).first()
+        and request.user.groups.filter(name=GROUP_WEBSITE_CONTENT_EDITORS).first()
         is not None
     )