Make sure enrollment_modes are always removed from mitxonline run dicts (#3033)

Author: mbertrand

learning_resources/etl/mitxonline.py

@@ -26,6 +26,7 @@
     get_department_id_by_name,
     parse_certification,
     parse_string_to_int,
+    strip_enrollment_modes,
     transform_price,
     transform_topics,
 )
@@ -314,6 +315,7 @@ def _transform_course(course):
         if course_run
     ]
     has_certification = parse_certification(OFFERED_BY["code"], runs)
+    strip_enrollment_modes(runs)
     return {
         "readable_id": course["readable_id"],
         "platform": PlatformType.mitxonline.name,
@@ -443,6 +445,7 @@ def transform_programs(programs: list[dict]) -> list[dict]:
             "max_weekly_hours": parse_string_to_int(program.get("max_weekly_hours")),
         }
         has_certification = parse_certification(OFFERED_BY["code"], [run])
+        strip_enrollment_modes([run])
         yield {
             "readable_id": program["readable_id"],
             "title": program["title"],

learning_resources/etl/mitxonline_test.py

@@ -39,6 +39,7 @@
     get_department_id_by_name,
     parse_certification,
     parse_string_to_int,
+    strip_enrollment_modes,
 )
 from learning_resources.test_utils import set_up_topics
 from main.test_utils import any_instance_of
@@ -145,6 +146,7 @@ def test_mitxonline_transform_programs(
                 for course_run in course_data["courseruns"]
             ]
             has_certification = parse_certification(OFFERED_BY["code"], runs)
+            strip_enrollment_modes(runs)
             expected_courses.append(
                 {
                     "readable_id": course_data["readable_id"],
@@ -303,6 +305,7 @@ def test_mitxonline_transform_courses(settings, mock_mitxonline_courses_data, mo
             for course_run in course_data["courseruns"]
         ]
         has_certification = parse_certification(OFFERED_BY["code"], runs)
+        strip_enrollment_modes(runs)
         expected.append(
             {
                 "readable_id": course_data["readable_id"],

learning_resources/etl/utils.py

@@ -1091,17 +1091,23 @@ def parse_certification(offeror, runs_data):
         run.get("status")
         and run.get("status") != RunStatus.archived.value
         and (
-            "enrollment_modes" not in run
+            run.get("enrollment_modes") is None
             or any(
                 mode.get("mode_slug") == "verified"
-                for mode in run.pop("enrollment_modes", [])
+                for mode in (run.get("enrollment_modes") or [])
             )
         )
         for run in runs_data
         if run.get("published", True)
     )
 
 
+def strip_enrollment_modes(runs_data):
+    """Remove enrollment_modes from run dicts before passing downstream."""
+    for run in runs_data:
+        run.pop("enrollment_modes", None)
+
+
 def iso8601_duration(duration_str: str) -> str | None:
     """
     Parse the duration from a string and return it in ISO-8601 format

learning_resources/etl/utils_test.py

@@ -23,6 +23,7 @@
     get_s3_prefix_for_source,
     parse_certification,
     parse_string_to_int,
+    strip_enrollment_modes,
 )
 from learning_resources.factories import (
     ContentFileFactory,
@@ -489,6 +490,30 @@ def test_parse_certification(offered_by, status, enrollment_modes, has_cert):
     assert parse_certification(offered_by_obj.code, runs) == has_cert
 
 
+def test_parse_certification_handles_explicit_none_enrollment_modes():
+    """A run with enrollment_modes=None should not error and should be treated as cert-eligible for MITx."""
+    runs = [
+        {
+            "published": True,
+            "status": RunStatus.current.value,
+            "enrollment_modes": None,
+        }
+    ]
+
+    assert parse_certification(OfferedBy.mitx.name, runs) is True
+
+
+def test_strip_enrollment_modes():
+    """strip_enrollment_modes should remove enrollment_modes from all run dicts."""
+    runs = [
+        {"status": "current", "enrollment_modes": [{"mode_slug": "verified"}]},
+        {"status": "current"},
+        {"status": "current", "enrollment_modes": None},
+    ]
+    strip_enrollment_modes(runs)
+    assert all("enrollment_modes" not in run for run in runs)
+
+
 @pytest.mark.parametrize(
     ("previous_archive", "identical"),
     [