Add authentication to load tests#3246
Merged
Merged
Conversation
OpenAPI ChangesNo changes detected Unexpected changes? Ensure your branch is up-to-date with |
rhysyngsun
force-pushed
the
nl/perf-tests-auth
branch
from
91b80b7 to
57bc8f5
Compare
rhysyngsun
force-pushed
the
nl/perf-tests-auth
branch
2 times, most recently
from
177d412 to
193b2f8
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rhysyngsun
force-pushed
the
nl/perf-tests-auth
branch
from
d6e51c8 to
1b402dc
Compare
mbertrand
requested changes
May 22, 2026
mbertrand
left a comment
mbertrand
left a comment
Member
There was a problem hiding this comment.
Got it working after some tweaks described here (running in WSL in case that matters). I added two users to the JSON file, one real and one fake.
The command I ran was slightly different since I don't have all the same aliases set up:
k6 run load_testing/learn.smoke.ts \
-e BACKEND_BASE_URL=http://open.odl.local:8065 \
-e FRONTEND_BASE_URL=http://open.odl.local:8062 \
-e SSO_BASE_URL=http://kc.ol.local:8066 \
-e USERS_JSON_FILE=data/users.json \
-e IGNORE_HTTPS_ERRORS=true \
--console-output test.log
Comment on lines
20
to
33
| @@ -18,35 +32,122 @@ async function home(page: Page) { | |||
| .click() | |||
| } | |||
Member
There was a problem hiding this comment.
Race condition + multi-element matcher. The data-testid mounts immediately as an empty wrapper; article children only appear after React Query resolves, so count() reads 0 and .nth(0).click() then hangs ~30s on a missing element. Also, the home page renders several ResourceCarousel instances — getByTestId matches them all; scope to first.
Suggested change
| async function home(page: Page, context: Context) { | |
| await page.goto(FRONTEND_BASE_URL) | |
| const carousel = page.getByTestId("resource-carousel").first() | |
| const articles = carousel.locator("article") | |
| try { | |
| await articles.first().waitFor({ timeout: 10_000 }) | |
| } catch { | |
| // carousel never populated; let the assertion below report it | |
| } | |
| const articlesCount = await articles.count() | |
| await check(carousel, { | |
| "home page carousel has 12 items": () => articlesCount === 12, | |
| }) | |
| if (articlesCount === 0) { | |
| return | |
| } | |
| await articles.nth(randomIntBetween(0, articlesCount - 1)).click() | |
| } |
rhysyngsun
force-pushed
the
nl/perf-tests-auth
branch
from
1b402dc to
2fe13dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Part of https://github.com/mitodl/hq/issues/11039
Description (What does it do?)
This adds code that logs the tests in via Keycloak so they can poke around as an authenticated user.
How can this be tested?
load_testing/data/(e.g.load_testing/data/users.json) per the readme instructions.test.log, you should see log statements regarding successful logins