Release 0.71.3#3452
Merged
Merged
Conversation
* fix: add link to the creation page of article and news --------- Co-authored-by: Ahtesham Quraish <ahtesham.quraish@192.168.1.6>
* fix(nextjs): make NEXT_PUBLIC env available on error pages notFound() and thrown render errors are served as a client-rendered HTML shell, not server-rendered through the root layout — so the inline PublicEnvScript <script> never executes and window.__ENV is unset. Any client env() read then returns undefined and requiredEnv() throws, blanking the page / triggering the global-error boundary. Emit NEXT_PUBLIC_* as an x-public-env <meta> from the root layout's static `metadata` (a <meta> is plain data, and metadata is still emitted into the error shell — even on global-error, where the layout component is bypassed) and have env() fall back to reading it. A static metadata object (not generateMetadata) reads process.env at module load = server start = runtime, and can't fail per-request and drop the meta. Both the meta and PublicEnvScript derive from a shared publicEnvObject() so they never diverge. ConfiguredPostHogProvider now reads via a new fullEnv() helper (same client meta-bootstrap as env()) instead of window.__ENV directly, so its bootstrap feature flags also resolve on error pages. Verified on not-found.tsx, error.tsx and global-error (env + Sentry init), cold and warm cache. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> one more comment one more comment fix typos comment, type * manually throw some errors * remove error debugging
OpenAPI ChangesNo changes detected Unexpected changes? Ensure your branch is up-to-date with |
odlbot
added
waiting for checkboxes
all checkboxes checked
and removed
deploying to rc
waiting for checkboxes
all checkboxes checked
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chris Chudzicki
Anastasia Beglova
Shankar Ambady
Ahtesham Quraish
Matt Bertrand