Align mitx-theme unauthenticated nav templates with upstream marketing-link changes#157
Closed
asadali145 with Copilot wants to merge 3 commits into
Closed
Align mitx-theme unauthenticated nav templates with upstream marketing-link changes#157asadali145 with Copilot wants to merge 3 commits into
asadali145 with Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Update theme templates to preserve MITx content
Align mitx-theme unauthenticated nav templates with upstream marketing-link changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
What's this PR do?
Removes the deprecated
ENABLE_MKTG_SITEgating from the MITx unauthenticated navbar overrides so marketing links render unconditionally, matching openedx-platform#38720 while preserving MITx-specific template behavior.Header navbar
mktg_site_enabledfromlms/templates/header/navbar-not-authenticated.htmlreverseandtext_typeimportsCOURSES_ARE_BROWSABLEaround the Courses linkLegacy nav variants
ENABLE_MKTG_SITEconditional from:lms/templates/navigation/navbar-not-authenticated.htmllms/templates/navigation/bootstrap/navbar-not-authenticated.htmlExample of the effective change:
- % if static.get_value('ENABLE_MKTG_SITE', settings.FEATURES.get('ENABLE_MKTG_SITE', False)): <a href="${marketing_link('HOW_IT_WORKS')}">${_("How it Works")}</a> % if settings.FEATURES.get('COURSES_ARE_BROWSABLE'): <a href="${marketing_link('COURSES')}">${_("Courses")}</a> % endif <a href="${marketing_link('SCHOOLS')}">${_("Schools")}</a> - % endifHow should this be manually tested?
COURSES_ARE_BROWSABLEis enabled)ENABLE_MKTG_SITEWhere should the reviewer start?
lms/templates/header/navbar-not-authenticated.htmllms/templates/navigation/navbar-not-authenticated.htmlAny background context you want to provide?
This repo does not contain the optional upstream-affected overrides for:
themes/stanford-style/lms/templates/footer.htmllms/templates/instructor/edx_ace/addbetatester/email/body.htmllms/templates/instructor/edx_ace/allowedenroll/email/body.htmlScreenshots (if appropriate)
N/A
What GIF best describes this PR or how it makes you feel?
N/A