Skip to content

feat: remove legacy settings for MKTG urls#88

Open
asadali145 with Copilot wants to merge 2 commits into
mainfrom
copilot/update-theme-templates
Open

feat: remove legacy settings for MKTG urls#88
asadali145 with Copilot wants to merge 2 commits into
mainfrom
copilot/update-theme-templates

Conversation

Copilot AI commented Jul 13, 2026

Copy link
Copy Markdown

What are the relevant tickets?

https://github.com/mitodl/hq/issues/12099

Description (What does it do?)

Removes the usage of legacy MKTG settings as per openedx/openedx-platform#38720

Testing

  • Checkout this branch and set the theme
  • Checkout feanil/depr_legacy_static branch in edx-platform.
  • In edx-platform:
FEATURES["ENABLE_MKTG_SITE"] = True
ENABLE_MKTG_SITE = True
MKTG_URLS = {
    "ROOT": "https://learn.mit.edu"
}

MKTG_URL_LINK_MAP = {}
#
MKTG_URL_OVERRIDES = {
    "COURSES": "https://learn.mit.edu",
    # "PRIVACY": "https://learn.mit.edu/privacy/",
    "TOS": "https://learn.mit.edu/terms-of-service/",
    "ABOUT": "https://learn.mit.edu/about/",
    # "HONOR": "https://learn.mit.edu/honor/",
    "ACCESSIBILITY": "https://accessibility.mit.edu/",
    "CONTACT": "mailto:mitlearn-support@mit.edu",
    "TOS_AND_HONOR": "",
}
MIT_LEARN_SUPPORT_SITE_LINK = "https://support.learn.mit.edu/"
  • Verify the legacy LMS pages have the links as per the above settings and they match the RC/Prod. There should be no impact.

Copilot AI changed the title [WIP] Update theme templates to match upstream changes Remove obsolete ENABLE_MKTG_SITE boilerplate from MITx Online navbar override Jul 13, 2026
Copilot AI requested a review from asadali145 July 13, 2026 13:05
@asadali145

Copy link
Copy Markdown
Contributor

@copilot rebase this PR with main

Copilot AI commented Jul 16, 2026

Copy link
Copy Markdown
Author

@copilot rebase this PR with main

Rebased onto main and pushed the updated branch at ea2f58c.

@asadali145
asadali145 force-pushed the copilot/update-theme-templates branch from 18e7857 to 13601b6 Compare July 16, 2026 11:13
@asadali145 asadali145 changed the title Remove obsolete ENABLE_MKTG_SITE boilerplate from MITx Online navbar override feat: remove legacy settings for MKTG urls Jul 16, 2026
@asadali145
asadali145 marked this pull request as ready for review July 16, 2026 12:00
@asadali145
asadali145 requested a review from Copilot July 16, 2026 12:00
@asadali145
asadali145 requested review from Anas12091101 and Copilot and removed request for asadali145 and Copilot July 16, 2026 12:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes unused legacy template imports and feature-flag variables from the unauthenticated navbar template, aligning the theme with the upstream removal of legacy MKTG settings.

Changes:

  • Drop unused imports (reverse, text_type) from the template module section.
  • Remove unused legacy feature-flag variable assignments (including ENABLE_MKTG_SITE) from the template context block.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Anas12091101 Anas12091101 self-assigned this Jul 17, 2026
@Anas12091101
Anas12091101 requested a review from Copilot July 17, 2026 08:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@Anas12091101 Anas12091101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Anas12091101

Anas12091101 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

We should merge this after Feanil's PR is merged: openedx/openedx-platform#38720.
Sorry, I meant to comment this on the ol-infra PR: mitodl/ol-infrastructure#5014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants