feat: remove legacy settings for MKTG urls#88
Open
asadali145 with Copilot wants to merge 2 commits into
Open
Conversation
Copilot
AI
changed the title
[WIP] Update theme templates to match upstream changes
Remove obsolete Jul 13, 2026
ENABLE_MKTG_SITE boilerplate from MITx Online navbar override
Contributor
|
@copilot rebase this PR with main |
Author
Rebased onto |
asadali145
force-pushed
the
copilot/update-theme-templates
branch
from
July 16, 2026 11:13
18e7857 to
13601b6
Compare
ENABLE_MKTG_SITE boilerplate from MITx Online navbar override
asadali145
marked this pull request as ready for review
July 16, 2026 12:00
asadali145
requested review from
Anas12091101 and
Copilot
and removed request for
asadali145 and
Copilot
July 16, 2026 12:00
There was a problem hiding this comment.
Pull request overview
Removes unused legacy template imports and feature-flag variables from the unauthenticated navbar template, aligning the theme with the upstream removal of legacy MKTG settings.
Changes:
- Drop unused imports (
reverse,text_type) from the template module section. - Remove unused legacy feature-flag variable assignments (including
ENABLE_MKTG_SITE) from the template context block.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/12099
Description (What does it do?)
Removes the usage of legacy MKTG settings as per openedx/openedx-platform#38720
Testing
feanil/depr_legacy_staticbranch in edx-platform.