Skip to content

Commit e7a31e9

Browse files
blarghmateyCopilot
andcommitted
fix(superset): change admin bypass RLS filter type from Base to Regular
The admin_engineer_analyst_course_scope_bypass filter was configured as filter_type 'Base', which Superset OR-combines with all Regular filters sharing the same group_key (course_scope). This caused instructor queries to receive (instructor_subquery OR 1=1), making the row-level restriction trivially true and exposing all course data to instructors. Changing to filter_type 'Regular' ensures Superset applies only the filter(s) matching the current user's role — instructors get the course subquery, admins/engineers/analysts get 1=1 (unrestricted). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 4c90cda commit e7a31e9

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/ol_superset/policies/ol_rls_policies.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@
3535
},
3636
{
3737
"name": "admin_engineer_analyst_course_scope_bypass",
38-
"description": "Base filter that exempts Admin, ol_data_engineer, and ol_data_analyst from all course-scope and term-expiry RLS on per-learner datasets. Engineers and platform admins need unrestricted access for pipeline development, data validation, and support. Data analysts (including education technologists supporting course teams across multiple courses) need unrestricted cross-course and cross-platform visibility for institutional analysis.",
39-
"filter_type": "Base",
38+
"description": "Regular filter that exempts Admin, ol_data_engineer, and ol_data_analyst from all course-scope and term-expiry RLS on per-learner datasets. Engineers and platform admins need unrestricted access for pipeline development, data validation, and support. Data analysts (including education technologists supporting course teams across multiple courses) need unrestricted cross-course and cross-platform visibility for institutional analysis.",
39+
"filter_type": "Regular",
4040
"group_key": "course_scope",
4141
"clause": "1 = 1",
4242
"tables": [

0 commit comments

Comments
 (0)