Fix page_engagement_views_report: platform joins, block category filters, and uniqueness test#1923
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add page engagement views report
Fix page_engagement_views_report: platform joins, block category filters, and uniqueness test
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
page_engagement_views_reporthad several correctness issues introduced in the initial implementation.Changes
Platform-conditional
dim_userjoins: Previously only joined onmitxonline_openedx_user_id, silently dropping users fromedxorg,mitxpro, andresidential. Now uses conditional joins per platform:block_categoryfilters onsubsection_blocksandsection_blocks: Without these filters, the CTEs included all block types, causing incorrect joins onsequential_block_fkandchapter_block_fk. Now filterssequentialandchapterrespectively.Removed unnecessary
GROUP BYfromcourse_runsCTE:int__combined__course_runsalready guarantees uniquecourserun_readable_idvalues.Added uniqueness test:
dbt_expectations.expect_compound_columns_to_be_uniqueon[user_email, courserun_readable_id, unit_title]to enforce expected grain.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.