Skip to content

Add search box and platform field to coupon dashboard #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KatelynGit merged 4 commits into from
Apr 28, 2026
+3 −0
Merged

Add search box and platform field to coupon dashboard #2187

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1cb23d
add search and platform field to coupon dashboard
KatelynGit Apr 28, 2026
c868bf2
chore: Deduplicate and
KatelynGit Apr 28, 2026
5719d20
chore: normalize Superset asset
KatelynGit Apr 28, 2026
9abb33b
fix: restore annotation_layers, comparison_color_scheme, order_desc, …
Copilot Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ..._superset/assets/charts/Coupon_Discount_Summary_2e066386-dc90-48e3-859b-2b665b3cb257.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ params:
color_pn: true
comparison_color_scheme: Green
comparison_type: values
conditional_formatting: []
extra_form_data: {}
groupby:
- couponpaymentversion_id
Expand Down Expand Up @@ -41,6 +42,8 @@ params:
- product_readable_id
- payment_transaction
- discount_max_redemptions
- platform
include_search: true
order_by_cols: []
order_desc: true
percent_metric_calculation: row_limit
Comment on lines +46 to 49
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update drops order_desc: true and server_page_length: 10 from the table chart params. That can change default sort direction and pagination behavior in the dashboard UI. If those behaviors should stay the same, please restore these params to their previous values and re-export/normalize the asset; if the change is intentional, document the intended new behavior and ensure QA validates it.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@KatelynGit KatelynGit Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copy link
Copy Markdown
Contributor

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored annotation_layers, comparison_color_scheme, order_desc: true, and server_page_length: 10 in commit 9abb33b. The diff now only contains the intended additions: platform in groupby, include_search: true, and conditional_formatting: [] (added by normalize).

Expand Down
Loading