Skip to content

add problem data to instructor reporting#2318

Open
KatelynGit wants to merge 11 commits into
mainfrom
add-org-table-report-kd061726
Open

add problem data to instructor reporting#2318
KatelynGit wants to merge 11 commits into
mainfrom
add-org-table-report-kd061726

Conversation

@KatelynGit

Copy link
Copy Markdown
Contributor

What are the relevant tickets?

https://github.com/mitodl/hq/issues/11464

Description (What does it do?)

add problem data to new instructor reporting table

How can this be tested?

dbt build --select instructor_module_problems_report

Copilot AI review requested due to automatic review settings June 17, 2026 19:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new dbt reporting model to support instructor-facing reporting by exposing learner-level problem attempt data joined to course/run, course structure (section/subsection), and organization metadata.

Changes:

  • Introduces instructor_module_problems_report SQL model that joins enrollments, users, problems, problem events, and course content hierarchy.
  • Documents the new model/columns in src/ol_dbt/models/reporting/_reporting__models.yml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.

File Description
src/ol_dbt/models/reporting/instructor_module_problems_report.sql New reporting query for learner problem attempts enriched with course structure and org/course metadata.
src/ol_dbt/models/reporting/_reporting__models.yml Adds model + column documentation for the new reporting table.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/ol_dbt/models/reporting/instructor_module_problems_report.sql
Comment thread src/ol_dbt/models/reporting/instructor_module_problems_report.sql
Comment thread src/ol_dbt/models/reporting/instructor_module_problems_report.sql Outdated
Comment thread src/ol_dbt/models/reporting/instructor_module_problems_report.sql
Comment thread src/ol_dbt/models/reporting/instructor_module_problems_report.sql
Comment thread src/ol_dbt/models/reporting/instructor_module_problems_report.sql
Comment thread src/ol_dbt/models/reporting/_reporting__models.yml Outdated
Comment thread src/ol_dbt/models/reporting/_reporting__models.yml Outdated
Comment thread src/ol_dbt/models/reporting/_reporting__models.yml Outdated
KatelynGit and others added 9 commits June 17, 2026 19:19
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@rachellougee rachellougee self-assigned this Jun 18, 2026

@rachellougee rachellougee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbt runs fine, I left two comments, both are worth addressing before merging

description: integer, row number indicating the latest row for each user based
on application and course run dates

- name: instructor_module_problems_report

@rachellougee rachellougee Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests in this new model? At minimum: not_null on user_email, courserun_readable_id, and problem_name. A unique combined key to prevent fan-out.

on
course_run.courserun_readable_id = problem.courserun_readable_id
and course_run.platform = problem.platform
left join problem_events

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This left join produced a lot of empty rows where attempt, success, and grade are all null have no actionable value

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they want to see when learners don't complete problems- however I agree it's too many records I'm checking with the requestor- waiting for a reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants