feat: hq-10825 enable residential features on mitxonline.#4629
Open
Ardiea wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the mitxonline Open edX (edxapp) infrastructure configuration to support Canvas integration and other “residential” feature toggles as part of consolidating MITx Residential courses into the mitxonline deployment.
Changes:
- Adds additional waffle flags for mitxonline CI/QA/Production stacks and introduces
edxapp:canvas_base_urlstack config. - Updates edxapp k8s interpolated config generation to trust Canvas for CSRF and include MIT IdP in CORS for mitxonline.
- Enables additional feature flags in the mitxonline
FEATURESconfig (Canvas integration, rapid response author view, instructor background tasks, higher problem response cap).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ol_infrastructure/applications/edxapp/Pulumi.mitxonline.QA.yaml | Adds new mitxonline waffle flags and sets edxapp:canvas_base_url. |
| src/ol_infrastructure/applications/edxapp/Pulumi.mitxonline.Production.yaml | Adds new mitxonline waffle flags and sets edxapp:canvas_base_url. |
| src/ol_infrastructure/applications/edxapp/Pulumi.mitxonline.CI.yaml | Adds new mitxonline waffle flags and sets edxapp:canvas_base_url. |
| src/ol_infrastructure/applications/edxapp/k8s_configmaps.py | Extends mitxonline-specific interpolated config (CORS/CSRF + Canvas base URL wiring). |
| src/ol_infrastructure/applications/edxapp/config_builder.py | Enables additional mitxonline feature flags relevant to residential/Canvas functionality. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+279
to
283
| config["CORS_ORIGIN_WHITELIST"].append("https://idp.mit.edu") | ||
| config["CSRF_TRUSTED_ORIGINS"] = [ | ||
| "https://canvas.mit.edu", | ||
| f"https://{domains['lms']}", | ||
| f"https://{domains['studio']}", |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/10825
Description (What does it do?)
As part of consolidating MITx Residential courses into the mitxonline deployment, several application-level configuration changes are needed in ol-infrastructure. These enable Canvas integration and other residential features, and reconcile conflicting settings between the two deployments.