ol_openedx_feedback: Per-block learner feedback in learning MFE#813
Open
zamanafzal wants to merge 1 commit into
Open
ol_openedx_feedback: Per-block learner feedback in learning MFE#813zamanafzal wants to merge 1 commit into
zamanafzal wants to merge 1 commit into
Conversation
zamanafzal
changed the title
3 tasks
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Adds the ol_openedx_feedback XBlockAside: a "Send feedback" trigger on applicable leaf blocks in the LMS student view. - Renders for authenticated, non-author users only; leaf blocks only (excludes course/chapter/sequential/vertical); gated per course by the ol_openedx_feedback.feedback_enabled CourseWaffleFlag. - On click, posts an ol-feedback::drawer-open message to the parent (Learning MFE) window. Trigger-only: no models, API, or migrations — the drawer UI and persistence live in the MFE and learn-ai. - Includes README, feedback.js/.css/.html assets, and aside tests.
zamanafzal
force-pushed
the
zafzal/11629-block-feedback
branch
from
69914af to
9ec8f0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Per-block content feedback — subtask mitodl/hq#11815 (RFC mitodl/hq#11812, parent mitodl/hq#11629).
Companion PRs:
mitodl/smoot-design#241— feedback drawer UI bundlemitodl/lehrer#83— Learning MFE slot wiringmitodl/learn-ai#556— backend endpoint + modelDescription (What does it do?)
Adds
ol_openedx_feedback, a lean trigger-onlyXBlockAsidethat renders a "Send feedback" megaphone on applicable blocks in the LMS student view. Feedback is not persisted in edx-platform — it is collected by the Learning MFE drawer and submitted to learn-ai.course/chapter/sequential/vertical); gated per course by theol_openedx_feedback.feedback_enabledCourseWaffleFlag.postMessagesol-feedback::drawer-opento the parent (Learning MFE) window with block context (courseId,blockUsageKey,blockType,blockDisplayName).apps.pyis aside-only (plugin_app = {}). The MFE owns the submit URL and enriches the payload withcourse_name/unit_title/url.How can this be tested?
ol_openedx_feedback.feedback_enabledCourseWaffleFlag (globally or per course).pytest src/ol_openedx_feedback/tests— coversshould_apply_to_block(waffle-flag gate + leaf-block filter + course-import branch) and student-view rendering (authenticated vs anonymous/author).Additional Context
The drawer UI ships in smoot-design (#241), the MFE slot wiring in lehrer (#83), and submissions are stored by learn-ai (#556). This PR is the LMS-side trigger only.