chore: update filename and fix sonarcloud error

adpare · adpare · commit 98e37624fa3b · 2026-01-21T21:22:57.000-05:00
diff --git a/mitreattack/attackToExcel/attackToExcel.py b/mitreattack/attackToExcel/attackToExcel.py
@@ -320,7 +320,7 @@ def write_excel(dataframes: Dict, domain: str, version: Optional[str] = None, ou
 
     # Write Detection strategy - Analytics - Log sources file
     ds_an_lg_frames = build_ds_an_lg_relationships(dataframes)
-    ds_an_lg_fp = os.path.join(output_directory, f"{domain_version_string}-detectionstrategy-anlytic-logsources.xlsx")
+    ds_an_lg_fp = os.path.join(output_directory, f"{domain_version_string}-detectionstrategy-analytic-logsources.xlsx")
 
     with pd.ExcelWriter(ds_an_lg_fp) as rel_writer:
         for sheet_name, df in ds_an_lg_frames.items():
diff --git a/mitreattack/attackToExcel/stixToDf.py b/mitreattack/attackToExcel/stixToDf.py
@@ -413,7 +413,6 @@ def analyticsToDf(src):
                     "detection_strategy_name": ds_info["detection_strategy_name"]
                 })
 
-        citations = get_citations(analytics)
         dataframes["analytics"] = (
             pd.DataFrame(analytic_rows).sort_values("name")
         )

Original file line number	Diff line number	Diff line change
`@@ -413,7 +413,6 @@ def analyticsToDf(src):`
`413`	`413`	`"detection_strategy_name": ds_info["detection_strategy_name"]`
`414`	`414`	`})`
`415`	`415`
`416`		`- citations = get_citations(analytics)`
`417`	`416`	`dataframes["analytics"] = (`
`418`	`417`	`pd.DataFrame(analytic_rows).sort_values("name")`
`419`	`418`	`)`