Preflight check + OVERQUOTA fatal-stop#1
Merged
Conversation
- New preflight AJAX action with a checklist (connection, folder list, quota fit with a 15% safety margin) that gates the Start migration button. The estimated source size vs. PHP max_execution_time also surfaces as an informational warning row when the ratio looks tight. - A runtime [OVERQUOTA] response on APPEND now stops the sync immediately via RoundcubeImapSyncQuotaExceededException + result.quotaExceeded, instead of producing one error per source message. The UI shows a localized "target mailbox is full" message instead of the raw IMAP response. - noticeretry now surfaces the concrete max_execution_time value of the installation; the unlimited case keeps the previous wording. - Adds a support notice with a GitHub Issues link below the migration form. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_execution_timeratio looks tight.[OVERQUOTA]IMAP response now stops the sync immediately with a localized "target mailbox is full" message, instead of producing one error per source message.max_execution_timein the notice — the "If something cuts the migration short" notice now states the concrete server-side time budget; the unlimited case keeps the previous wording.Breaking changes
None. New AJAX action (
plugin.imapsync.preflight) and new public client methods (getFolderSize,getQuota,supportsStatusSize) are additive. Existing locale keys are unchanged; one new key (noticeretrylimit) is selected at render time whenmax_execution_time > 0.How to verify
plugins/imapsync) per the README.composer test:unitcovers the engine paths (17 tests, 62 assertions including 5 new ones for preflight + OVERQUOTA). UI flow (verify → checklist → gating → stale-input invalidation) is not exercised by the unit suite — manual browser verification is needed before merge.🤖 Generated with Claude Code