fix(ts-plugin): exclude re-exported @value tokens from Go to Definition results

Re-exported tokens from `@value ... from '...'` were being returned as
definition candidates, even though the actual definition lives in the
imported file. Filter them out so Go to Definition only returns the
original definition.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: mizdra

.changeset/exclude-reexport-goto-def.md

@@ -0,0 +1,5 @@
+---
+'@css-modules-kit/ts-plugin': patch
+---
+
+fix(ts-plugin): exclude re-exported `@value ... from '...'` tokens from Go to Definition results

packages/ts-plugin/e2e-test/feature/go-to-definition.test.ts

@@ -226,96 +226,60 @@ describe.each([
           file: iff.paths['index.ts'],
           line: 7,
           offset: 8,
-          // NOTE: Ideally, only the definition from c.module.css should be returned.
-          // However, for simplicity of implementation, when `namedExports: false`, the definition from a.module.css is also returned.
           expected: [
-            !namedExports && {
-              file: formatPath(iff.paths['a.module.css']),
-              start: { line: 2, offset: 8 },
-              end: { line: 2, offset: 11 },
-              contextStart: { line: 2, offset: 8 },
-              contextEnd: { line: 2, offset: 11 },
-            },
             {
               file: formatPath(iff.paths['c.module.css']),
               start: { line: 1, offset: 8 },
               end: { line: 1, offset: 11 },
               contextStart: { line: 1, offset: 1 },
               contextEnd: { line: 1, offset: 16 },
             },
-          ].filter((c) => c !== false),
+          ],
         },
         {
           name: 'c_1 in a.module.ts',
           file: iff.paths['a.module.css'],
           line: 2,
           offset: 8,
-          // NOTE: Ideally, only the definition from c.module.css should be returned.
-          // However, for simplicity of implementation, when `namedExports: false`, the definition from a.module.css is also returned.
           expected: [
-            !namedExports && {
-              file: formatPath(iff.paths['a.module.css']),
-              start: { line: 2, offset: 8 },
-              end: { line: 2, offset: 11 },
-              contextStart: { line: 2, offset: 8 },
-              contextEnd: { line: 2, offset: 11 },
-            },
             {
               file: formatPath(iff.paths['c.module.css']),
               start: { line: 1, offset: 8 },
               end: { line: 1, offset: 11 },
               contextStart: { line: 1, offset: 1 },
               contextEnd: { line: 1, offset: 16 },
             },
-          ].filter((c) => c !== false),
+          ],
         },
         {
           name: 'c_alias in index.ts',
           file: iff.paths['index.ts'],
           line: 8,
           offset: 8,
-          // NOTE: Ideally, only the definition from c.module.css should be returned.
-          // However, for simplicity of implementation, when `namedExports: false`, the definition from a.module.css is also returned.
           expected: [
-            !namedExports && {
-              file: formatPath(iff.paths['a.module.css']),
-              start: { line: 2, offset: 20 },
-              end: { line: 2, offset: 27 },
-              contextStart: { line: 2, offset: 20 },
-              contextEnd: { line: 2, offset: 27 },
-            },
             {
               file: formatPath(iff.paths['c.module.css']),
               start: { line: 2, offset: 8 },
               end: { line: 2, offset: 11 },
               contextStart: { line: 2, offset: 1 },
               contextEnd: { line: 2, offset: 16 },
             },
-          ].filter((c) => c !== false),
+          ],
         },
         {
           name: 'c_alias in a.module.css',
           file: iff.paths['a.module.css'],
           line: 2,
           offset: 20,
-          // NOTE: Ideally, only the definition from c.module.css should be returned.
-          // However, for simplicity of implementation, when `namedExports: false`, the definition from a.module.css is also returned.
           expected: [
-            !namedExports && {
-              file: formatPath(iff.paths['a.module.css']),
-              start: { line: 2, offset: 20 },
-              end: { line: 2, offset: 27 },
-              contextStart: { line: 2, offset: 20 },
-              contextEnd: { line: 2, offset: 27 },
-            },
             {
               file: formatPath(iff.paths['c.module.css']),
               start: { line: 2, offset: 8 },
               end: { line: 2, offset: 11 },
               contextStart: { line: 2, offset: 1 },
               contextEnd: { line: 2, offset: 16 },
             },
-          ].filter((c) => c !== false),
+          ],
         },
         {
           name: 'c_2 in a.module.css',

packages/ts-plugin/src/language-service/feature/definition-and-bound-span.ts

@@ -10,9 +10,9 @@ export function getDefinitionAndBoundSpan(
     const result = languageService.getDefinitionAndBoundSpan(...args);
     if (!result) return;
     if (!result.definitions) return result;
-    for (const def of result.definitions) {
+    result.definitions = result.definitions.filter((def) => {
       const script = language.scripts.get(def.fileName);
-      if (!isCSSModuleScript(script)) continue;
+      if (!isCSSModuleScript(script)) return true;
 
       const cssModule = script.generated.root[CMK_DATA_KEY];
 
@@ -26,23 +26,20 @@ export function getDefinitionAndBoundSpan(
           start: localToken.declarationLoc.start.offset,
           length: localToken.declarationLoc.end.offset - localToken.declarationLoc.start.offset,
         };
-        continue;
+        return true;
       }
+      // Exclude re-exported tokens from `@value ... from '...'`; the real definition lives in the target file.
       const importedValue = cssModule.tokenImporters
         .flatMap((i) => (i.type === 'value' ? i.values : []))
         .find((v) => {
           const localName = v.localName ?? v.name;
           const localLoc = v.localLoc ?? v.loc;
           return localName === defName && localLoc.start.offset === def.textSpan.start;
         });
-      if (importedValue) {
-        const loc = importedValue.localLoc ?? importedValue.loc;
-        def.contextSpan = {
-          start: loc.start.offset,
-          length: loc.end.offset - loc.start.offset,
-        };
-      }
-    }
+      if (importedValue) return false;
+
+      return true;
+    });
     return result;
   };
 }