Skip to content

[RFC] JSDoc for hovering#179

Closed
ssssota wants to merge 12 commits into
mizdra:mainfrom
ssssota:jsdoc-for-hovering
Closed

[RFC] JSDoc for hovering#179
ssssota wants to merge 12 commits into
mizdra:mainfrom
ssssota:jsdoc-for-hovering

Conversation

@ssssota
Copy link
Copy Markdown

@ssssota ssssota commented May 9, 2025

ref. #135 #44

To inspect CSS definition from your JS files.

Same aproach as #44 and refined it.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 9, 2025

⚠️ No Changeset found

Latest commit: 4cae3a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mizdra
Copy link
Copy Markdown
Owner

mizdra commented May 10, 2025

This PR looks like a draft. Is there anything you would like me to do? Should I review the PR immediately, or should I wait until it is no longer in draft status?

@ssssota
Copy link
Copy Markdown
Author

ssssota commented May 10, 2025

I forgot to mention that it was in draft for self review.
This PR is ready for review. Please review it!

@ssssota ssssota marked this pull request as ready for review May 10, 2025 18:21
@mizdra mizdra force-pushed the jsdoc-for-hovering branch from 682915f to 99e1ac0 Compare June 14, 2025 14:43
Comment thread packages/core/src/parser/at-value-parser.ts Outdated
@mizdra
Copy link
Copy Markdown
Owner

mizdra commented Jun 15, 2025

@ssssota I checked the behavior of this change. As a result, I found the following pros and cons.

Pros

Cons

  • It is not a common way to implement definition previews.
    • It may not work properly in some editors.
  • Value declaration preview does not work correctly.
  • Indentation of nested rules is incorrect.
    • image

After evaluating the overall situation, I believe that #197 is the better implementation method. I will close #179 and continue working on #197.

This Pull Request will be closed, but the ideas gained from it were very inspiring. Thank you for your contribution!

@mizdra mizdra closed this Jun 15, 2025
@ssssota ssssota deleted the jsdoc-for-hovering branch June 15, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants