Skip to content

Definition Context for Hover Info#197

Merged
mizdra merged 6 commits into
mainfrom
definition-context-for-hovering
Jun 15, 2025
Merged

Definition Context for Hover Info#197
mizdra merged 6 commits into
mainfrom
definition-context-for-hovering

Conversation

@mizdra
Copy link
Copy Markdown
Owner

@mizdra mizdra commented Jun 15, 2025

ref: #135, #179

With this PR, users will be able to preview token definitions in VS Code using Cmd + Hover.

This feature is implemented by setting the location of the token definition in the contextStart/contextEnd properties of the definitionAndBoundSpan response.

Preview

2025-06-15.23.33.23.mov

Pros

Cons

@mizdra mizdra added the Type: Feature New Feature label Jun 15, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 15, 2025

🦋 Changeset detected

Latest commit: b690b34

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@css-modules-kit/ts-plugin Minor
@css-modules-kit/core Minor
css-modules-kit-vscode Patch
@css-modules-kit/codegen Patch
@css-modules-kit/stylelint-plugin Patch
@css-modules-kit/eslint-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mizdra mizdra force-pushed the definition-context-for-hovering branch from 99dc29f to 0ef8a41 Compare June 15, 2025 13:04
@mizdra mizdra changed the title RFC: Definition Context for Hover Info Definition Context for Hover Info Jun 15, 2025
@mizdra mizdra mentioned this pull request Jun 15, 2025
@mizdra
Copy link
Copy Markdown
Owner Author

mizdra commented Jun 15, 2025

This is a movie for README.

2025-06-16.0.25.40.mov

@mizdra mizdra force-pushed the definition-context-for-hovering branch from 9762e19 to b690b34 Compare June 15, 2025 15:52
@mizdra
Copy link
Copy Markdown
Owner Author

mizdra commented Jun 15, 2025

I tried to check if it works with Zed, but it seems that Zed does not support definition preview by hover.

@mizdra mizdra merged commit 15209ea into main Jun 15, 2025
10 checks passed
@mizdra mizdra deleted the definition-context-for-hovering branch June 15, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant