Disallow non-JavaScript identifier @value#221
Merged
Conversation
🦋 Changeset detectedLatest commit: 25cf2ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mizdra
force-pushed
the
fix-non-js-ident-value
branch
from
420d5a1 to
25cf2ef
Compare
mizdra
changed the title
@value@value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
css-modules-kit does not expect non-JavaScript identifiers to be used in class names,
@value, or@keyframes. If non-JavaScript identifiers are used, various issues may arise.Therefore, css-modules-kit reports an error if the names of classes or
@keyframesare non-JavaScript identifiers. However, it seems that support for@valuewas missing. This is a bug, so we fix it.