fix(core): resolve relative dtsOutDir against defining tsconfig directory#373
Merged
fix(core): resolve relative dtsOutDir against defining tsconfig directory#373
Conversation
…tory
Previously, `dtsOutDir` defined in a base tsconfig was resolved relative
to the entry tsconfig directory. Now relative paths are resolved against
the tsconfig file that defines them, matching TypeScript's behavior for
options like `outDir`. Use `${configDir}` to opt into consumer-relative
resolution.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: dec0539 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from: #370 (comment)
Summary
dtsOutDirresolution so that relative paths defined in an extended tsconfig are resolved against the directory of the tsconfig that defines them, matching TypeScript's behavior for options likeoutDir.dtsOutDirwas always resolved relative to the entry tsconfig directory, which produced surprising results when inheriting from another tsconfig in a different directory.${configDir}continue to resolve relative to the entry (consumer) tsconfig directory.Test plan
vp testpasses (190 unit tests, 304 total)resolves relative paths against the defining tsconfig directorytest passes