Add Ability to Land in Water Safely

[ampersand38]

When merged this pull request will:

• Add helper to make backpacks float
• Allow lowered/cut chestpacks to float if landing in water
• Allow players to discard their parachute while swimming
• Improve positions with ASL
• Fix some backpacks not hidden in MP
• https://youtu.be/I2FtUAgbHxo
• https://youtu.be/VEhGd-ZBARs

[mjc4wilton]

Overall code looks fine. Just a few things regarding format / naming. I'm going to hold off on merging until I can playtest it a bit which I would have done already provided that I didn't just come back from vacation to find that my hard drive with all my dev tools and dev environment has died.

[mjc4wilton]

Alright pointed out a few things I found from playtesting. For reference these are the requirements I want to put on this PR before I merge it just to ensure everything is working in a rather simple way:

• Chestpack floats when dropped into water
• Chestpack doesn't have a float when dropped onto land
• If player has a parachute equipped with a chestpack, allow them to drop the parachute via ACE interact regardless of land / water
• Items shouldn't be auto-deleted. If they are, have that tied to a CBA setting to enable it. (at least when it comes to gear)
• No errors thrown to screen or log
• No use of #, just use select.

[mjc4wilton]

Suggested change

	if (hasInterface) then {
	_holder addaction ["Discard", {
	// Make pack sink
	((_this # 0) getVariable QGVAR(float) setMass 10000);
	}, nil, 7, true, true, "", "firstBackpack _target isKindOf 'B_Parachute'"];
	};

This addaction is broken it seems since it add an action to discard whatever backpack you have if you are swimming. Additionally, I'd much rather muddle around and shove actions into ace than an infinite scroll menu since that just gets annoying.

[ampersand38]

This action should actually get added to the weaponHolder that is holding the used parachute that has just been discarded, and would make it sink and get deleted once it's no longer relevant to the player. I felt it was on the same sort of level as the Release vanilla action you get when escorting a prisoner. Should this be done in an ace action?

[mjc4wilton]

Leave it as an ACE action as to not clutter up the scroll menu since I personally hate it (the menu not your feature). As for the feature itself, decouple it from the action so a function can call it to sink a pack which would probably be more useful for those making automated cleanup scripts and the like.

[mjc4wilton]

Apologies for review taking longer. Aparantly github needs them to be published now in addition to adding the comments?

[ampersand38]

needs them to be published now

No worries. I found that out to my surprise on the H-60 project too xD