Skip to content

Enhance Microsoft Authentication API for better account management #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mjcheetham wants to merge 7 commits into
base: new-protocol
Choose a base branch
from
Draft

Enhance Microsoft Authentication API for better account management #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
63e4db9
msauth: extract and rename SPI class to own file
mjcheetham Jun 8, 2026
a2f0c64
msauth: rename MicrosoftAuthenticationFlowType and make private
mjcheetham Jun 8, 2026
06c674a
msauth: add IMicrosoftAuthentication.GetUserAccountsAsync
mjcheetham Jun 8, 2026
575c4f7
msauth: surface the full account from authentication results
mjcheetham Jun 8, 2026
31b9635
msauth: add RemoveUserAccountAsync
mjcheetham Jun 10, 2026
3782cd1
msauth: accept IMicrosoftAccount on GetTokenForUserAsync
mjcheetham Jun 11, 2026
d8a8069
msauth: surface the authentication flow on the result
mjcheetham Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/shared/Core.Tests/Authentication/MicrosoftAuthenticationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public async Task MicrosoftAuthentication_GetTokenForUserAsync_NoInteraction_Thr
const string clientId = "C9E8FDA6-1D46-484C-917C-3DBD518F27C3";
Uri redirectUri = new Uri("https://localhost");
string[] scopes = {"user.read"};
const string userName = null; // No user to ensure we do not use an existing token
IMicrosoftAccount account = null; // No account to ensure we do not use an existing token

var context = new TestCommandContext
{
Expand All @@ -26,7 +26,7 @@ public async Task MicrosoftAuthentication_GetTokenForUserAsync_NoInteraction_Thr
var msAuth = new MicrosoftAuthentication(context);

await Assert.ThrowsAsync<Trace2InvalidOperationException>(
() => msAuth.GetTokenForUserAsync(authority, clientId, redirectUri, scopes, userName, false));
() => msAuth.GetTokenForUserAsync(authority, clientId, redirectUri, scopes, account, false));
}

[Theory]
Expand Down
Loading