Skip to content

Commit 9144451

Browse files
black-deskgitster
authored andcommitted
b4: include change-id in cover template
With b4 0.15.2, I hit a local failure after sending a series with the in-tree cover template. The generated sent/<change-id>-vN tag contained base-commit, but did not contain change-id, and later b4 commands failed when trying to read it: CRITICAL: Tag sent/... does not contain change-id info Looking at b4's source, the sent tag message is derived from the rendered cover letter. The same code later parses that tag and expects both base-commit and change-id to be present. The default b4 cover template has both trailers, but our in-tree template only has base-commit. Add the missing change-id trailer next to base-commit so sent tags produced from the project template remain readable by b4's reroll and comparison logic. Signed-off-by: Chen Linxuan <me@black-desk.cn> Acked-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent f85a7e6 commit 9144451

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

.b4-cover-template

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,5 @@ ${diffstat}
88
${range_diff}
99
---
1010
base-commit: ${base_commit}
11+
change-id: ${change_id}
1112
${prerequisites}

0 commit comments

Comments
 (0)