fix(player): resolve shortcut pause failure caused by state oscillation (#174)

* fix(player): resolve shortcut pause failure caused by state oscillation

Remove problematic automatic retry mechanisms in PlayerOrchestrator that were causing infinite state oscillation loops between play and pause operations.

**Problem**:
- Shortcut pause commands (spacebar) would fail and immediately resume playback
- Logs showed repeating "Video element still playing after pause() call" warnings
- Root cause: setTimeout-based verification logic in requestPlay() and requestPause() created mutual triggering loops

**Solution**:
- Remove 150ms retry logic from requestPlay() (lines 283-297)
- Remove 50ms retry logic from requestPause() (lines 320-333)
- Remove verification timeouts from requestTogglePlay() (lines 345-360)
- Trust browser's native play()/pause() API reliability

**Impact**:
- ✅ Shortcut pause now works immediately without interference
- ✅ Eliminates state oscillation loop warnings from logs
- ✅ Mouse click controls remain unaffected
- ✅ All other player functionality preserved

Fixes #170

* test: update PlayerOrchestrator tests to reflect removed retry mechanisms

Update reliability tests that previously validated automatic retry behavior:

- 'should detect play failure in delayed verification' → 'should only call play once without retry'
- 'should detect pause failure in delayed verification' → 'should only call pause once without retry'

These tests now correctly validate the simplified behavior where play() and pause()
are called exactly once without automatic retry mechanisms, aligning with the fix
that removes state oscillation loops.

All 578 tests now pass ✅

Author: mkdir700

src/renderer/src/pages/player/engine/PlayerOrchestrator.ts

@@ -278,23 +278,6 @@ export class PlayerOrchestrator {
 
       await this.videoController.play()
       logger.debug('Command: requestPlay executed successfully')
-
-      // 延迟验证播放是否真正开始
-      setTimeout(() => {
-        if (this.videoController?.isPaused()) {
-          logger.warn('Video element still paused after play() call, investigating...', {
-            contextPaused: this.context.paused,
-            videoPaused: this.videoController?.isPaused()
-          })
-
-          // 尝试再次播放
-          this.videoController?.play().catch((retryError) => {
-            logger.error('Retry play() also failed:', { retryError })
-            // 回滚乐观更新
-            this.updateContext({ paused: true })
-          })
-        }
-      }, 150)
     } catch (error) {
       logger.error('Failed to execute requestPlay:', { error })
       // 回滚乐观更新
@@ -333,21 +316,6 @@ export class PlayerOrchestrator {
 
       this.videoController.pause()
       logger.debug('Command: requestPause executed successfully')
-
-      // 延迟验证暂停是否真正生效
-      setTimeout(() => {
-        if (!this.videoController?.isPaused()) {
-          logger.warn('Video element still playing after pause() call, investigating...', {
-            contextPaused: this.context.paused,
-            videoPaused: this.videoController?.isPaused()
-          })
-
-          // 尝试再次暂停
-          this.videoController?.pause()
-          // 强制同步状态
-          this.syncPlaybackState()
-        }
-      }, 50)
     } catch (error) {
       logger.error('Failed to execute requestPause:', { error })
       // 回滚乐观更新
@@ -373,22 +341,8 @@ export class PlayerOrchestrator {
     try {
       if (isPaused) {
         await this.requestPlay()
-        // 验证播放操作是否成功
-        setTimeout(() => {
-          if (this.videoController?.isPaused() && !this.context.paused) {
-            logger.warn('Play command failed to take effect, attempting sync')
-            this.syncPlaybackState()
-          }
-        }, 100)
       } else {
         this.requestPause()
-        // 验证暂停操作是否成功
-        setTimeout(() => {
-          if (!this.videoController?.isPaused() && this.context.paused) {
-            logger.warn('Pause command failed to take effect, attempting sync')
-            this.syncPlaybackState()
-          }
-        }, 50)
       }
     } catch (error) {
       logger.error('Failed to toggle play state:', { error, isPaused })

src/renderer/src/pages/player/engine/__tests__/PlayerOrchestrator.playback-reliability.test.ts

@@ -211,17 +211,17 @@ describe('PlayerOrchestrator - 播放/暂停可靠性测试', () => {
       expect(finalContext.paused).toBe(true)
     })
 
-    it('应该在延迟验证中检测播放失败', async () => {
+    it('应该只调用一次play而不进行重试', async () => {
       orchestrator.updateContext({ paused: true })
       mockVideoController.isPaused.mockReturnValue(true) // 播放后仍然是暂停状态
 
       await orchestrator.requestPlay()
 
-      // 等待延迟验证执行
+      // 等待可能的延迟操作
       await new Promise((resolve) => setTimeout(resolve, 200))
 
-      // 应该尝试重试播放
-      expect(mockVideoController.play).toHaveBeenCalledTimes(2) // 一次正常调用，一次重试
+      // 应该只调用一次play，不进行重试（修复后的行为）
+      expect(mockVideoController.play).toHaveBeenCalledTimes(1)
     })
   })
 
@@ -236,17 +236,17 @@ describe('PlayerOrchestrator - 播放/暂停可靠性测试', () => {
       expect(context.paused).toBe(true)
     })
 
-    it('应该在延迟验证中检测暂停失败', async () => {
+    it('应该只调用一次pause而不进行重试', async () => {
       orchestrator.updateContext({ paused: false })
       mockVideoController.isPaused.mockReturnValue(false) // 暂停后仍然是播放状态
 
       orchestrator.requestPause()
 
-      // 等待延迟验证
+      // 等待可能的延迟操作
       await new Promise((resolve) => setTimeout(resolve, 100))
 
-      // 应该尝试重试暂停
-      expect(mockVideoController.pause).toHaveBeenCalledTimes(2)
+      // 应该只调用一次pause，不进行重试（修复后的行为）
+      expect(mockVideoController.pause).toHaveBeenCalledTimes(1)
     })
   })