fix(build): Fix FFmpeg cross-platform build on macOS for Windows targets (#145)

* fix(build): fix FFmpeg cross-platform build on macOS for Windows targets

- Add cross-env dependency for cross-platform environment variables
- Update Windows build scripts to set BUILD_TARGET_PLATFORM and BUILD_TARGET_ARCH
- Modify download-ffmpeg.ts to prioritize environment variables over command arguments
- Update vite plugin to avoid duplicate FFmpeg downloads
- Fix release scripts to download all platform FFmpeg binaries before building
- Ensure correct FFmpeg binaries are included for each target platform

Resolves issue where building Windows packages on macOS would include macOS FFmpeg binaries instead of Windows ones.

* fix(build): improve FFmpeg download in CI environments

- Replace direct tsx command with npm run for better CI compatibility
- Add CI-specific handling with proper environment variable passing
- Convert hard failures to warnings to prevent CI build blocking
- Improve error messages and debugging information

Fixes Windows CI build failure: spawn tsx ENOENT

* fix(build): ensure FFmpeg is properly downloaded in Windows CI

- Use npm run ffmpeg:download on Windows for better compatibility
- Pass environment variables to ensure correct platform detection
- Throw errors on download failure to prevent incomplete builds
- Keep direct tsx usage on Unix systems for performance

This ensures CI builds never skip FFmpeg download and always include
the correct FFmpeg binaries for the target platform.

Author: mkdir700

electron.vite.config.ts

@@ -18,21 +18,49 @@ function ffmpegDownloadPlugin() {
       // 只在生产构建时下载 FFmpeg
       if (!isProd) return
 
-      console.log('Downloading FFmpeg...')
+      // 根据构建目标决定下载哪个平台
+      const targetPlatform = process.env.BUILD_TARGET_PLATFORM || process.platform
+      const targetArch = process.env.BUILD_TARGET_ARCH || process.arch
+
+      // 检查是否已存在，避免重复下载
+      const ffmpegPath = path.resolve(
+        'resources/ffmpeg',
+        `${targetPlatform}-${targetArch}`,
+        targetPlatform === 'win32' ? 'ffmpeg.exe' : 'ffmpeg'
+      )
+
+      if (fs.existsSync(ffmpegPath)) {
+        console.log(`FFmpeg already exists for ${targetPlatform}-${targetArch}`)
+        return
+      }
 
-      try {
-        // 根据构建目标决定下载哪个平台
-        const targetPlatform = process.env.BUILD_TARGET_PLATFORM || process.platform
-        const targetArch = process.env.BUILD_TARGET_ARCH || process.arch
+      console.log(`Downloading FFmpeg for ${targetPlatform}-${targetArch}...`)
 
+      try {
         await new Promise<void>((resolve, reject) => {
-          const downloadScript = spawn(
-            'tsx',
-            ['scripts/download-ffmpeg.ts', 'platform', targetPlatform, targetArch],
-            {
-              stdio: 'inherit'
+          // 在不同环境中使用不同的命令来确保兼容性
+          let command: string
+          let args: string[]
+
+          if (process.platform === 'win32') {
+            // Windows 环境：使用 npm run 调用脚本，更可靠
+            command = 'npm'
+            args = ['run', 'ffmpeg:download']
+          } else {
+            // Unix 环境：直接使用 tsx
+            command = 'tsx'
+            args = ['scripts/download-ffmpeg.ts', 'platform', targetPlatform, targetArch]
+          }
+
+          const downloadScript = spawn(command, args, {
+            stdio: 'inherit',
+            shell: process.platform === 'win32',
+            env: {
+              ...process.env,
+              BUILD_TARGET_PLATFORM: targetPlatform,
+              BUILD_TARGET_ARCH: targetArch
             }
-          )
+          })
 
           downloadScript.on('close', (code) => {
             if (code === 0) {
@@ -48,7 +76,8 @@ function ffmpegDownloadPlugin() {
           })
         })
       } catch (error) {
-        console.warn('FFmpeg Download failed', error)
+        console.error('FFmpeg Download failed:', error)
+        throw new Error(`Failed to download FFmpeg for ${targetPlatform}-${targetArch}: ${error}`)
       }
     }
   }

package.json

@@ -20,11 +20,12 @@
     "start": "electron-vite preview",
     "dev": "electron-vite dev",
     "build": "npm run typecheck && electron-vite build",
+    "build:release": "npm run typecheck && electron-vite build",
     "postinstall": "electron-builder install-app-deps",
     "build:unpack": "npm run build && electron-builder --dir --publish never",
-    "build:win": "npm run build && electron-builder --win --publish never",
-    "build:win:x64": "npm run build && electron-builder --win --x64 --publish never",
-    "build:win:arm64": "npm run build && electron-builder --win --arm64 --publish never",
+    "build:win": "cross-env BUILD_TARGET_PLATFORM=win32 npm run build && electron-builder --win --publish never",
+    "build:win:x64": "cross-env BUILD_TARGET_PLATFORM=win32 BUILD_TARGET_ARCH=x64 npm run build && electron-builder --win --x64 --publish never",
+    "build:win:arm64": "cross-env BUILD_TARGET_PLATFORM=win32 BUILD_TARGET_ARCH=arm64 npm run build && electron-builder --win --arm64 --publish never",
     "build:mac": "electron-vite build && electron-builder --mac --publish never",
     "build:mac:x64": "npm run build && electron-builder --mac --x64 --publish never",
     "build:mac:arm64": "npm run build && electron-builder --mac --arm64 --publish never",
@@ -47,10 +48,10 @@
     "version:prerelease": "tsx scripts/version-manager.ts prerelease",
     "version:beta": "tsx scripts/version-manager.ts minor beta",
     "version:beta-patch": "tsx scripts/version-manager.ts patch beta",
-    "release": "npm run build && electron-builder --publish onTagOrDraft",
-    "release:all": "npm run build && electron-builder --publish always",
-    "release:never": "npm run build && electron-builder --publish never",
-    "release:draft": "npm run build && electron-builder --publish onTagOrDraft",
+    "release": "npm run ffmpeg:download-all && npm run build:release && electron-builder --publish onTagOrDraft",
+    "release:all": "npm run ffmpeg:download-all && npm run build:release && electron-builder --publish always",
+    "release:never": "npm run ffmpeg:download-all && npm run build:release && electron-builder --publish never",
+    "release:draft": "npm run ffmpeg:download-all && npm run build:release && electron-builder --publish onTagOrDraft",
     "migrate": "tsx src/main/db/migration-cli.ts",
     "migrate:up": "npm run migrate up",
     "migrate:down": "npm run migrate down",
@@ -71,7 +72,8 @@
     "ffmpeg:download-all": "tsx scripts/download-ffmpeg.ts all",
     "ffmpeg:clean": "tsx scripts/download-ffmpeg.ts clean",
     "ffmpeg:test": "tsx scripts/test-ffmpeg-integration.ts",
-    "prebuild": "npm run ffmpeg:download"
+    "prebuild": "npm run ffmpeg:download",
+    "prebuild:release": "echo 'FFmpeg already downloaded by release script'"
   },
   "dependencies": {
     "@ant-design/icons": "^6.0.1",
@@ -128,6 +130,7 @@
     "@welldone-software/why-did-you-render": "^10.0.1",
     "cli-progress": "^3.12.0",
     "code-inspector-plugin": "^1.2.7",
+    "cross-env": "^10.0.0",
     "electron": "37.2.4",
     "electron-builder": "26.0.19",
     "electron-devtools-installer": "^4.0.0",

pnpm-lock.yaml

@@ -376,11 +376,28 @@ class FFmpegDownloader {
 // CLI 入口
 async function main() {
   const args = process.argv.slice(2)
-  const command = args[0] || 'current'
+  let command = args[0]
 
   const downloader = new FFmpegDownloader()
 
   try {
+    // 优先检查环境变量，如果设置了构建目标则使用目标平台
+    if (process.env.BUILD_TARGET_PLATFORM) {
+      console.log(
+        `检测到构建目标平台: ${process.env.BUILD_TARGET_PLATFORM}-${process.env.BUILD_TARGET_ARCH || process.arch}`
+      )
+      await downloader.downloadFFmpeg(
+        process.env.BUILD_TARGET_PLATFORM,
+        process.env.BUILD_TARGET_ARCH || process.arch
+      )
+      return
+    }
+
+    // 如果没有环境变量，按原逻辑处理命令参数
+    if (!command) {
+      command = 'current'
+    }
+
     switch (command) {
       case 'all':
         await downloader.downloadAllPlatforms()
@@ -416,6 +433,10 @@ async function main() {
   win32: x64, arm64
   darwin: x64, arm64
   linux: x64, arm64
+
+环境变量:
+  BUILD_TARGET_PLATFORM - 构建目标平台 (win32, darwin, linux)
+  BUILD_TARGET_ARCH     - 构建目标架构 (x64, arm64)
         `)
     }
   } catch (error) {