Commit 3e46a69
committed
fix(player): resolve spacebar shortcut not working after clicking to pause (#182)
* fix(player): resolve spacebar shortcut not working after clicking to pause
- Remove duplicate onKeyDown handler from VideoSurface component that was intercepting space key events and preventing global shortcuts from working
- Add enhanced debug logging to track shortcut trigger events and focus state
- Ensure consistent play/pause behavior regardless of focus location
Fixes issue where clicking VideoSurface to pause would prevent spacebar from resuming playback
* test: fix Windows timing race conditions in VideoLibraryDAO tests
- Replace multiple Date.now() calls with fixed timestamps to prevent 1ms differences
- Use consistent FIXED_NOW and FIXED_FIRST_PLAYED_AT constants across all mock data
- Fix failing tests on Windows where Date.now() calls had microsecond variations
Resolves test failures where expected timestamps differed by 1ms from actual values1 parent 9a9d932 commit 3e46a69
3 files changed
Lines changed: 22 additions & 17 deletions
File tree
- src
- main/db/dao/__tests__
- renderer/src/pages/player
- components
- hooks
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
15 | 19 | | |
16 | 20 | | |
17 | 21 | | |
18 | 22 | | |
19 | 23 | | |
20 | | - | |
21 | | - | |
| 24 | + | |
| 25 | + | |
22 | 26 | | |
23 | 27 | | |
24 | 28 | | |
| |||
30 | 34 | | |
31 | 35 | | |
32 | 36 | | |
33 | | - | |
34 | | - | |
| 37 | + | |
| 38 | + | |
35 | 39 | | |
36 | 40 | | |
37 | 41 | | |
| |||
43 | 47 | | |
44 | 48 | | |
45 | 49 | | |
46 | | - | |
47 | | - | |
| 50 | + | |
| 51 | + | |
48 | 52 | | |
49 | 53 | | |
50 | 54 | | |
| |||
155 | 159 | | |
156 | 160 | | |
157 | 161 | | |
158 | | - | |
| 162 | + | |
| 163 | + | |
159 | 164 | | |
160 | 165 | | |
161 | 166 | | |
| |||
262 | 267 | | |
263 | 268 | | |
264 | 269 | | |
265 | | - | |
| 270 | + | |
266 | 271 | | |
267 | 272 | | |
268 | 273 | | |
| |||
279 | 284 | | |
280 | 285 | | |
281 | 286 | | |
282 | | - | |
| 287 | + | |
283 | 288 | | |
284 | 289 | | |
285 | 290 | | |
| |||
295 | 300 | | |
296 | 301 | | |
297 | 302 | | |
298 | | - | |
| 303 | + | |
299 | 304 | | |
300 | 305 | | |
301 | 306 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
208 | 208 | | |
209 | 209 | | |
210 | 210 | | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | 211 | | |
218 | 212 | | |
219 | 213 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
100 | 106 | | |
101 | | - | |
| 107 | + | |
102 | 108 | | |
103 | 109 | | |
104 | 110 | | |
| |||
0 commit comments